rooty/LibrePilot
1
0
Fork 0
mirror of https://bitbucket.org/librepilot/librepilot.git synced 2025-01-29 14:52:12 +01:00
Code Issues Releases Activity

OP-834 added FIXME comment for bad Q_ASSERT around effective code and

Browse Source 
commented out a bunch of dead code (that dead code includes the suspicious
Q_ASSERT uses)
This commit is contained in:
Philippe Renon 2013-02-09 17:50:45 +01:00 committed by Alessio Morale
parent 43786badfa
commit 6d75dd0c6f
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ground/openpilotgcs/src/plugins/notify/notifytablemodel.cpp
View File

@ -174,13 +174,16 @@ Qt::DropActions NotifyTableModel::supportedDropActions() const
return Qt::MoveAction; return Qt::MoveAction;
} }
/*
QStringList NotifyTableModel::mimeTypes() const QStringList NotifyTableModel::mimeTypes() const
{ {
QStringList types; QStringList types;
types << mime_type_notify_table; types << mime_type_notify_table;
return types; return types;
} }
*/
/*
bool NotifyTableModel::dropMimeData( const QMimeData * data, Qt::DropAction action, int row, bool NotifyTableModel::dropMimeData( const QMimeData * data, Qt::DropAction action, int row,
int column, const QModelIndex& parent) int column, const QModelIndex& parent)
{ {
@ -225,8 +228,10 @@ bool NotifyTableModel::dropMimeData( const QMimeData * data, Qt::DropAction acti
// addiional check in case dropping of multiple rows // addiional check in case dropping of multiple rows
if(rows + direction > _list.size()) continue; if(rows + direction > _list.size()) continue;
// FIXME: suspicious Q_ASSERT around effective code
Q_ASSERT(insertRows(rows + direction, 1, QModelIndex())); Q_ASSERT(insertRows(rows + direction, 1, QModelIndex()));
_list.replace(rows + direction, item); _list.replace(rows + direction, item);
// FIXME: suspicious Q_ASSERT around effective code
Q_ASSERT(removeRows(dragged, 1, QModelIndex())); Q_ASSERT(removeRows(dragged, 1, QModelIndex()));
if (direction == UP_DIRECTION) if (direction == UP_DIRECTION)
++rows; ++rows;
@ -237,7 +242,9 @@ bool NotifyTableModel::dropMimeData( const QMimeData * data, Qt::DropAction acti
emit dataChanged(idxTopLeft, idxBotRight); emit dataChanged(idxTopLeft, idxBotRight);
return true; return true;
} }
*/
/*
QMimeData* NotifyTableModel::mimeData(const QModelIndexList& indexes) const QMimeData* NotifyTableModel::mimeData(const QModelIndexList& indexes) const
{ {
QMimeData* mimeData = new QMimeData(); QMimeData* mimeData = new QMimeData();
@ -255,6 +262,7 @@ QMimeData* NotifyTableModel::mimeData(const QModelIndexList& indexes) const
mimeData->setData(mime_type_notify_table, encodedData); mimeData->setData(mime_type_notify_table, encodedData);
return mimeData; return mimeData;
} }
*/
void NotifyTableModel::dropRows(int position, int count) const void NotifyTableModel::dropRows(int position, int count) const
{ {

8
ground/openpilotgcs/src/plugins/notify/notifytablemodel.h
View File

@ -61,11 +61,11 @@ public:
return QAbstractItemModel::flags(index) | Qt::ItemIsEditable | Qt::ItemIsDragEnabled | Qt::ItemIsDropEnabled; return QAbstractItemModel::flags(index) | Qt::ItemIsEditable | Qt::ItemIsDragEnabled | Qt::ItemIsDropEnabled;
} }
QStringList mimeTypes() const; //QStringList mimeTypes() const;
Qt::DropActions supportedDropActions() const; Qt::DropActions supportedDropActions() const;
bool dropMimeData( const QMimeData * data, Qt::DropAction action, int row, //bool dropMimeData( const QMimeData * data, Qt::DropAction action, int row,
int column, const QModelIndex& parent); // int column, const QModelIndex& parent);
QMimeData* mimeData(const QModelIndexList &indexes) const; //QMimeData* mimeData(const QModelIndexList &indexes) const;
bool setData(const QModelIndex &index, const QVariant &value, int role); bool setData(const QModelIndex &index, const QVariant &value, int role);