From 81e10c9d1b65038ecf593dfd2368a087cb5a1b87 Mon Sep 17 00:00:00 2001
From: Alessio Morale <alessiomorale@gmail.com>
Date: Tue, 21 May 2013 00:15:18 +0200
Subject: [PATCH] OP-960 Prevent a warning to appear each time an alarm not in
 svg is received +review OPReview

---
 .../systemhealth/systemhealthgadgetwidget.cpp | 46 +++++++++++--------
 .../systemhealth/systemhealthgadgetwidget.h   |  2 +-
 2 files changed, 28 insertions(+), 20 deletions(-)

diff --git a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp
index 38f62569d..a1e4c8908 100644
--- a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp
+++ b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.cpp
@@ -48,7 +48,7 @@ SystemHealthGadgetWidget::SystemHealthGadgetWidget(QWidget *parent) : QGraphicsV
     background = new QGraphicsSvgItem();
     foreground = new QGraphicsSvgItem();
     nolink     = new QGraphicsSvgItem();
-
+    missingElements = new QStringList();
     paint();
 
     // Now connect the widget to the SystemAlarms UAVObject
@@ -100,26 +100,32 @@ void SystemHealthGadgetWidget::updateAlarms(UAVObject *systemAlarm)
         for (uint i = 0; i < field->getNumElements(); ++i) {
             QString element = field->getElementNames()[i];
             QString value   = field->getValue(i).toString();
-            if (m_renderer->elementExists(element)) {
-                QMatrix blockMatrix = m_renderer->matrixForElement(element);
-                qreal startX = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).x();
-                qreal startY = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).y();
-                QString element2    = element + "-" + value;
-                if (m_renderer->elementExists(element2)) {
-                    QGraphicsSvgItem *ind = new QGraphicsSvgItem();
-                    ind->setSharedRenderer(m_renderer);
-                    ind->setElementId(element2);
-                    ind->setParentItem(background);
-                    QTransform matrix;
-                    matrix.translate(startX, startY);
-                    ind->setTransform(matrix, false);
-                } else {
-                    if (value.compare("Uninitialised") != 0) {
-                        qDebug() << "Warning: element " << element2 << " not found in SVG.";
+            if (!missingElements->contains(element)){
+                if (m_renderer->elementExists(element)) {
+                    QMatrix blockMatrix = m_renderer->matrixForElement(element);
+                    qreal startX = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).x();
+                    qreal startY = blockMatrix.mapRect(m_renderer->boundsOnElement(element)).y();
+                    QString element2    = element + "-" + value;
+                    if (!missingElements->contains(element2)) {
+                        if (m_renderer->elementExists(element2)) {
+                            QGraphicsSvgItem *ind = new QGraphicsSvgItem();
+                            ind->setSharedRenderer(m_renderer);
+                            ind->setElementId(element2);
+                            ind->setParentItem(background);
+                            QTransform matrix;
+                            matrix.translate(startX, startY);
+                            ind->setTransform(matrix, false);
+                        } else {
+                            if (value.compare("Uninitialised") != 0) {
+                                missingElements->append(element2);
+                                qDebug() << "Warning: element " << element2 << " not found in SVG.";
+                            }
+                        }
                     }
+                } else {
+                    missingElements->append(element);
+                    qDebug() << "Warning: Element " << element << " not found in SVG.";
                 }
-            } else {
-                qDebug() << "Warning: Element " << element << " not found in SVG.";
             }
         }
     }
@@ -133,6 +139,8 @@ SystemHealthGadgetWidget::~SystemHealthGadgetWidget()
 
 void SystemHealthGadgetWidget::setSystemFile(QString dfn)
 {
+    // Clear the list of elements not found on svg
+    missingElements->clear();
     setBackgroundBrush(QBrush(Utils::StyleHelper::baseColor()));
     if (QFile::exists(dfn)) {
         m_renderer->load(dfn);
diff --git a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h
index a76c58e1a..c48526382 100644
--- a/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h
+++ b/ground/openpilotgcs/src/plugins/systemhealth/systemhealthgadgetwidget.h
@@ -64,7 +64,7 @@ private:
     QGraphicsSvgItem *background;
     QGraphicsSvgItem *foreground;
     QGraphicsSvgItem *nolink;
-
+    QStringList *missingElements;
     // Simple flag to skip rendering if the
     bool fgenabled; // layer does not exist.