rooty/LibrePilot
1
0
Fork 0
mirror of https://bitbucket.org/librepilot/librepilot.git synced 2025-02-18 08:54:15 +01:00
Code Issues Releases Activity

OP-1383 minor improvment to original fix + better comment

Browse Source
This commit is contained in:
Philippe Renon 2014-07-15 00:02:16 +02:00
parent ef785bd060
commit 859cb59df9
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ground/openpilotgcs/src/plugins/uavtalk/telemetrymanager.cpp
View File

@ -53,8 +53,12 @@ bool TelemetryManager::isConnected()
void TelemetryManager::start(QIODevice *dev)
{
device = dev;
// take ownership of the device (the why is not clear?)
device->moveToThread(Core::ICore::instance()->threadManager()->getRealTimeThread());
// OP-1383
// take ownership of the device by moving it to the TelemetryManager thread (see TelemetryManager constructor)
// this removes the following runtime Qt warning and incidentally fixes GCS crashes:
// QObject: Cannot create children for a parent that is in a different thread.
// (Parent is QSerialPort(0x56af73f8), parent's thread is QThread(0x23f69ae8), current thread is QThread(0x2649cfd8)
device->moveToThread(thread());
emit myStart();
}