From 9e870e6ae383a6f55b7f0dcb31c1cd39fa3ed2e4 Mon Sep 17 00:00:00 2001
From: Fredrik Arvidsson <fredrik@arvidssons.org>
Date: Sun, 3 Mar 2013 14:17:37 +0100
Subject: [PATCH] OP-856 Added enabling/disabling of required modules depending
 on port configuration. Added rules for port configuration.

---
 .../src/plugins/config/configrevohwwidget.cpp | 118 ++++++++++-
 .../src/plugins/config/configrevohwwidget.h   |   4 +-
 .../src/plugins/config/configrevohwwidget.ui  | 195 +++++++++---------
 3 files changed, 209 insertions(+), 108 deletions(-)

diff --git a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp
index 532dc3b48..e383b5221 100644
--- a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp
+++ b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.cpp
@@ -30,6 +30,8 @@
 #include <extensionsystem/pluginmanager.h>
 #include <coreplugin/generalsettings.h>
 #include "hwsettings.h"
+#include <QDesktopServices>
+#include <QUrl>
 
 
 ConfigRevoHWWidget::ConfigRevoHWWidget(QWidget *parent) : ConfigTaskWidget(parent)
@@ -45,6 +47,7 @@ ConfigRevoHWWidget::ConfigRevoHWWidget(QWidget *parent) : ConfigTaskWidget(paren
     }
 
     addApplySaveButtons(m_ui->saveTelemetryToRAM, m_ui->saveTelemetryToSD);
+
     addUAVObjectToWidgetRelation("HwSettings","RM_FlexiPort",m_ui->cbFlexi);
     addUAVObjectToWidgetRelation("HwSettings","RM_MainPort",m_ui->cbMain);
     addUAVObjectToWidgetRelation("HwSettings","RM_RcvrPort",m_ui->cbRcvr);
@@ -62,6 +65,9 @@ ConfigRevoHWWidget::ConfigRevoHWWidget(QWidget *parent) : ConfigTaskWidget(paren
     addUAVObjectToWidgetRelation("HwSettings","ComUsbBridgeSpeed",m_ui->cbMainComSpeed);
 
     addUAVObjectToWidgetRelation("HwSettings","RadioPort",m_ui->cbModem);
+
+    connect(m_ui->cchwHelp,SIGNAL(clicked()),this,SLOT(openHelp()));
+
     setupCustomCombos();
     enableControls(true);
     populateWidgets();
@@ -86,6 +92,7 @@ void ConfigRevoHWWidget::setupCustomCombos()
 
     connect(m_ui->cbFlexi, SIGNAL(currentIndexChanged(int)), this, SLOT(flexiPortChanged(int)));
     connect(m_ui->cbMain, SIGNAL(currentIndexChanged(int)), this, SLOT(mainPortChanged(int)));
+    connect(m_ui->cbModem, SIGNAL(currentIndexChanged(int)), this, SLOT(modemPortChanged(int)));
 
 }
 
@@ -105,6 +112,39 @@ void ConfigRevoHWWidget::refreshWidgetsValues(UAVObject *obj)
     flexiPortChanged(0);
 }
 
+void ConfigRevoHWWidget::updateObjectsFromWidgets()
+{
+    ConfigTaskWidget::updateObjectsFromWidgets();
+
+    HwSettings *hwSettings = HwSettings::GetInstance(getObjectManager());
+    HwSettings::DataFields data = hwSettings->getData();
+
+    // If any port is configured to be GPS port, enable GPS module if it is not enabled.
+    // Otherwise disable GPS module.
+    if(m_ui->cbFlexi->currentIndex() == HwSettings::RM_FLEXIPORT_GPS || m_ui->cbMain->currentIndex() == HwSettings::RM_MAINPORT_GPS) {
+        if(data.OptionalModules[HwSettings::OPTIONALMODULES_GPS] != HwSettings::OPTIONALMODULES_ENABLED) {
+            data.OptionalModules[HwSettings::OPTIONALMODULES_GPS] = HwSettings::OPTIONALMODULES_ENABLED;
+        }
+    }
+    else if(data.OptionalModules[HwSettings::OPTIONALMODULES_GPS] != HwSettings::OPTIONALMODULES_DISABLED) {
+        data.OptionalModules[HwSettings::OPTIONALMODULES_GPS] = HwSettings::OPTIONALMODULES_DISABLED;
+    }
+
+    // If any port is configured to be ComBridge port, enable UsbComBridge module if it is not enabled.
+    // Otherwise disable UsbComBridge module.
+    if(m_ui->cbFlexi->currentIndex() == HwSettings::RM_FLEXIPORT_COMBRIDGE || m_ui->cbMain->currentIndex() == HwSettings::RM_MAINPORT_COMBRIDGE ||
+            m_ui->cbUSBVCPFunction->currentIndex() == HwSettings::USB_VCPPORT_COMBRIDGE) {
+        if(data.OptionalModules[HwSettings::OPTIONALMODULES_COMUSBBRIDGE] != HwSettings::OPTIONALMODULES_ENABLED) {
+            data.OptionalModules[HwSettings::OPTIONALMODULES_COMUSBBRIDGE] = HwSettings::OPTIONALMODULES_ENABLED;
+        }
+    }
+    else if(data.OptionalModules[HwSettings::OPTIONALMODULES_COMUSBBRIDGE] != HwSettings::OPTIONALMODULES_DISABLED) {
+        data.OptionalModules[HwSettings::OPTIONALMODULES_COMUSBBRIDGE] = HwSettings::OPTIONALMODULES_DISABLED;
+    }
+
+    hwSettings->setData(data);
+}
+
 void ConfigRevoHWWidget::usbTypeChanged(int index)
 {
     Q_UNUSED(index);
@@ -115,8 +155,30 @@ void ConfigRevoHWWidget::usbTypeChanged(int index)
 
     m_ui->lblUSBVCPSpeed->setVisible(!hid);
     m_ui->cbUSBVCPSpeed->setVisible(!hid);
+
+    if(hid){
+        m_ui->cbUSBVCPFunction->setCurrentIndex(HwSettings::USB_VCPPORT_DISABLED);
+        m_ui->cbUSBHIDFunction->setCurrentIndex(HwSettings::USB_HIDPORT_USBTELEMETRY);
+    }
+    else {
+        m_ui->cbUSBHIDFunction->setCurrentIndex(HwSettings::USB_HIDPORT_DISABLED);
+        m_ui->cbUSBVCPFunction->setCurrentIndex(HwSettings::USB_VCPPORT_USBTELEMETRY);
+    }
+
+    if(m_ui->cbFlexi->currentIndex() == HwSettings::RM_FLEXIPORT_COMBRIDGE) {
+        m_ui->cbFlexi->setCurrentIndex(HwSettings::RM_FLEXIPORT_DISABLED);
+    }
+    m_ui->cbFlexi->model()->setData(m_ui->cbFlexi->model()->index(HwSettings::RM_FLEXIPORT_COMBRIDGE, 0),
+                                    hid ? QVariant(0) : QVariant(1|32), Qt::UserRole - 1);
+
+    if(m_ui->cbMain->currentIndex() == HwSettings::RM_MAINPORT_COMBRIDGE) {
+        m_ui->cbMain->setCurrentIndex(HwSettings::RM_MAINPORT_DISABLED);
+    }
+    m_ui->cbMain->model()->setData(m_ui->cbMain->model()->index(HwSettings::RM_MAINPORT_COMBRIDGE, 0),
+                                   hid ? QVariant(0) : QVariant(1|32), Qt::UserRole - 1);
 }
 
+
 void ConfigRevoHWWidget::flexiPortChanged(int index)
 {
     Q_UNUSED(index);
@@ -126,17 +188,28 @@ void ConfigRevoHWWidget::flexiPortChanged(int index)
     m_ui->cbFlexiComSpeed->setVisible(false);
     m_ui->lblFlexiSpeed->setVisible(true);
 
-    int value = m_ui->cbFlexi->currentIndex();
-    switch(value)
+    switch(m_ui->cbFlexi->currentIndex())
     {
         case HwSettings::RM_FLEXIPORT_TELEMETRY:
             m_ui->cbFlexiTelemSpeed->setVisible(true);
+            if(m_ui->cbMain->currentIndex() == HwSettings::RM_MAINPORT_TELEMETRY) {
+                m_ui->cbMain->setCurrentIndex(HwSettings::RM_MAINPORT_DISABLED);
+            }
+            if(m_ui->cbModem->currentIndex() == HwSettings::RADIOPORT_TELEMETRY) {
+                m_ui->cbModem->setCurrentIndex(HwSettings::RADIOPORT_DISABLED);
+            }
             break;
         case HwSettings::RM_FLEXIPORT_GPS:
             m_ui->cbFlexiGPSSpeed->setVisible(true);
+            if(m_ui->cbMain->currentIndex() == HwSettings::RM_MAINPORT_GPS) {
+                m_ui->cbMain->setCurrentIndex(HwSettings::RM_MAINPORT_DISABLED);
+            }
             break;
         case HwSettings::RM_FLEXIPORT_COMBRIDGE:
             m_ui->cbFlexiComSpeed->setVisible(true);
+            if(m_ui->cbMain->currentIndex() == HwSettings::RM_MAINPORT_COMBRIDGE) {
+                m_ui->cbMain->setCurrentIndex(HwSettings::RM_MAINPORT_DISABLED);
+            }
             break;
         default:
             m_ui->lblFlexiSpeed->setVisible(false);
@@ -153,17 +226,28 @@ void ConfigRevoHWWidget::mainPortChanged(int index)
     m_ui->cbMainComSpeed->setVisible(false);
     m_ui->lblMainSpeed->setVisible(true);
 
-    int value = m_ui->cbMain->currentIndex();
-    switch(value)
+    switch(m_ui->cbMain->currentIndex())
     {
-        case HwSettings::RM_FLEXIPORT_TELEMETRY:
+        case HwSettings::RM_MAINPORT_TELEMETRY:
             m_ui->cbMainTelemSpeed->setVisible(true);
+            if(m_ui->cbFlexi->currentIndex() == HwSettings::RM_FLEXIPORT_TELEMETRY) {
+                m_ui->cbFlexi->setCurrentIndex(HwSettings::RM_FLEXIPORT_DISABLED);
+            }
+            if(m_ui->cbModem->currentIndex() == HwSettings::RADIOPORT_TELEMETRY) {
+                m_ui->cbModem->setCurrentIndex(HwSettings::RADIOPORT_DISABLED);
+            }
             break;
-        case HwSettings::RM_FLEXIPORT_GPS:
+        case HwSettings::RM_MAINPORT_GPS:
             m_ui->cbMainGPSSpeed->setVisible(true);
+            if(m_ui->cbFlexi->currentIndex() == HwSettings::RM_FLEXIPORT_GPS) {
+                m_ui->cbFlexi->setCurrentIndex(HwSettings::RM_FLEXIPORT_DISABLED);
+            }
             break;
-        case HwSettings::RM_FLEXIPORT_COMBRIDGE:
+        case HwSettings::RM_MAINPORT_COMBRIDGE:
             m_ui->cbMainComSpeed->setVisible(true);
+            if(m_ui->cbFlexi->currentIndex() == HwSettings::RM_FLEXIPORT_COMBRIDGE) {
+                m_ui->cbFlexi->setCurrentIndex(HwSettings::RM_FLEXIPORT_DISABLED);
+            }
             break;
         default:
             m_ui->lblMainSpeed->setVisible(false);
@@ -171,9 +255,21 @@ void ConfigRevoHWWidget::mainPortChanged(int index)
     }
 }
 
-/**
-  Request telemetry settings from the board
-  */
-void ConfigRevoHWWidget::refreshValues()
+void ConfigRevoHWWidget::modemPortChanged(int index)
 {
+    Q_UNUSED(index);
+
+    if(m_ui->cbModem->currentIndex()== HwSettings::RADIOPORT_TELEMETRY) {
+        if(m_ui->cbMain->currentIndex() == HwSettings::RM_MAINPORT_TELEMETRY) {
+            m_ui->cbMain->setCurrentIndex(HwSettings::RM_MAINPORT_DISABLED);
+        }
+        if(m_ui->cbFlexi->currentIndex() == HwSettings::RM_FLEXIPORT_TELEMETRY) {
+            m_ui->cbFlexi->setCurrentIndex(HwSettings::RM_FLEXIPORT_DISABLED);
+        }
+    }
+}
+
+void ConfigRevoHWWidget::openHelp()
+{
+    QDesktopServices::openUrl( QUrl("http://wiki.openpilot.org/x/GgDBAQ", QUrl::StrictMode) );
 }
diff --git a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h
index 7e4bd4c16..6615411d5 100644
--- a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h
+++ b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.h
@@ -51,12 +51,14 @@ private:
 
 protected slots:
     void refreshWidgetsValues(UAVObject * obj = NULL);
+    void updateObjectsFromWidgets();
 
 private slots:
-    virtual void refreshValues();
     void usbTypeChanged(int index);
     void flexiPortChanged(int index);
     void mainPortChanged(int index);
+    void modemPortChanged(int index);
+    void openHelp();
 
 };
 
diff --git a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.ui b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.ui
index 6814108c9..b78c40975 100644
--- a/ground/openpilotgcs/src/plugins/config/configrevohwwidget.ui
+++ b/ground/openpilotgcs/src/plugins/config/configrevohwwidget.ui
@@ -93,6 +93,9 @@
            </disabled>
           </palette>
          </property>
+         <property name="styleSheet">
+          <string notr="true">border-color: rgb(255, 0, 0);</string>
+         </property>
          <property name="frameShape">
           <enum>QFrame::NoFrame</enum>
          </property>
@@ -107,106 +110,14 @@
            <rect>
             <x>0</x>
             <y>0</y>
-            <width>806</width>
-            <height>654</height>
+            <width>810</width>
+            <height>665</height>
            </rect>
           </property>
           <layout class="QGridLayout" name="gridLayout_3">
            <property name="margin">
             <number>12</number>
            </property>
-           <item row="5" column="2">
-            <spacer name="verticalSpacer">
-             <property name="orientation">
-              <enum>Qt::Vertical</enum>
-             </property>
-             <property name="sizeHint" stdset="0">
-              <size>
-               <width>20</width>
-               <height>25</height>
-              </size>
-             </property>
-            </spacer>
-           </item>
-           <item row="0" column="2">
-            <widget class="QLabel" name="label_6">
-             <property name="sizePolicy">
-              <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
-               <horstretch>0</horstretch>
-               <verstretch>0</verstretch>
-              </sizepolicy>
-             </property>
-             <property name="minimumSize">
-              <size>
-               <width>500</width>
-               <height>0</height>
-              </size>
-             </property>
-             <property name="maximumSize">
-              <size>
-               <width>500</width>
-               <height>16777215</height>
-              </size>
-             </property>
-             <property name="font">
-              <font>
-               <weight>75</weight>
-               <bold>true</bold>
-              </font>
-             </property>
-             <property name="text">
-              <string>Changes on this page only take effect after board reset or power cycle</string>
-             </property>
-             <property name="alignment">
-              <set>Qt::AlignCenter</set>
-             </property>
-             <property name="wordWrap">
-              <bool>true</bool>
-             </property>
-            </widget>
-           </item>
-           <item row="2" column="0">
-            <spacer name="horizontalSpacer_4">
-             <property name="orientation">
-              <enum>Qt::Horizontal</enum>
-             </property>
-             <property name="sizeHint" stdset="0">
-              <size>
-               <width>40</width>
-               <height>20</height>
-              </size>
-             </property>
-            </spacer>
-           </item>
-           <item row="1" column="2">
-            <spacer name="verticalSpacer_2">
-             <property name="orientation">
-              <enum>Qt::Vertical</enum>
-             </property>
-             <property name="sizeType">
-              <enum>QSizePolicy::Fixed</enum>
-             </property>
-             <property name="sizeHint" stdset="0">
-              <size>
-               <width>20</width>
-               <height>10</height>
-              </size>
-             </property>
-            </spacer>
-           </item>
-           <item row="2" column="3">
-            <spacer name="horizontalSpacer_5">
-             <property name="orientation">
-              <enum>Qt::Horizontal</enum>
-             </property>
-             <property name="sizeHint" stdset="0">
-              <size>
-               <width>40</width>
-               <height>20</height>
-              </size>
-             </property>
-            </spacer>
-           </item>
            <item row="2" column="2">
             <layout class="QGridLayout" name="gridLayout" rowstretch="0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0">
              <item row="11" column="5">
@@ -260,7 +171,7 @@
                 </sizepolicy>
                </property>
                <property name="text">
-                <string>Function</string>
+                <string>USB Function</string>
                </property>
                <property name="alignment">
                 <set>Qt::AlignBottom|Qt::AlignHCenter</set>
@@ -368,7 +279,7 @@
                 </sizepolicy>
                </property>
                <property name="text">
-                <string>USB Type</string>
+                <string>USB Port</string>
                </property>
                <property name="alignment">
                 <set>Qt::AlignBottom|Qt::AlignHCenter</set>
@@ -602,6 +513,98 @@
              </item>
             </layout>
            </item>
+           <item row="0" column="2">
+            <widget class="QLabel" name="label_6">
+             <property name="sizePolicy">
+              <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
+               <horstretch>0</horstretch>
+               <verstretch>0</verstretch>
+              </sizepolicy>
+             </property>
+             <property name="minimumSize">
+              <size>
+               <width>0</width>
+               <height>0</height>
+              </size>
+             </property>
+             <property name="maximumSize">
+              <size>
+               <width>16777215</width>
+               <height>16777215</height>
+              </size>
+             </property>
+             <property name="font">
+              <font>
+               <weight>75</weight>
+               <bold>true</bold>
+              </font>
+             </property>
+             <property name="text">
+              <string>Changes on this page only take effect after board reset or power cycle</string>
+             </property>
+             <property name="alignment">
+              <set>Qt::AlignCenter</set>
+             </property>
+             <property name="wordWrap">
+              <bool>true</bool>
+             </property>
+            </widget>
+           </item>
+           <item row="1" column="2">
+            <spacer name="verticalSpacer_2">
+             <property name="orientation">
+              <enum>Qt::Vertical</enum>
+             </property>
+             <property name="sizeType">
+              <enum>QSizePolicy::Fixed</enum>
+             </property>
+             <property name="sizeHint" stdset="0">
+              <size>
+               <width>20</width>
+               <height>10</height>
+              </size>
+             </property>
+            </spacer>
+           </item>
+           <item row="2" column="0">
+            <spacer name="horizontalSpacer_4">
+             <property name="orientation">
+              <enum>Qt::Horizontal</enum>
+             </property>
+             <property name="sizeHint" stdset="0">
+              <size>
+               <width>40</width>
+               <height>20</height>
+              </size>
+             </property>
+            </spacer>
+           </item>
+           <item row="2" column="3">
+            <spacer name="horizontalSpacer_5">
+             <property name="orientation">
+              <enum>Qt::Horizontal</enum>
+             </property>
+             <property name="sizeHint" stdset="0">
+              <size>
+               <width>40</width>
+               <height>20</height>
+              </size>
+             </property>
+            </spacer>
+           </item>
+           <item row="3" column="2">
+            <spacer name="verticalSpacer">
+             <property name="orientation">
+              <enum>Qt::Vertical</enum>
+             </property>
+             <property name="sizeHint" stdset="0">
+              <size>
+               <width>20</width>
+               <height>40</height>
+              </size>
+             </property>
+            </spacer>
+           </item>
           </layout>
          </widget>
         </widget>