rooty/LibrePilot
1
0
Fork 0
mirror of https://bitbucket.org/librepilot/librepilot.git synced 2025-02-27 16:54:15 +01:00
Code Issues Releases Activity

OP-1453 - Remove QNetworkAccessManager when we're done with it. Other

Browse Source 
minor tweaks arising from review.
This commit is contained in:
dwillis 2014-08-24 23:50:26 +01:00
parent 8230f0915c
commit b3f1c0281b
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ground/openpilotgcs/src/plugins/welcome/welcomemode.cpp
View File

@ -91,7 +91,10 @@ WelcomeMode::WelcomeMode() :
WelcomeMode::~WelcomeMode()
{
delete m_d->quickView;
delete m_d->networkAccess;
// This may or may not have been scheduled for deletion elsewhere. Should
// be safe to call this again if it has already been scheduled.
m_d->networkAccess->deleteLater();
delete m_d;
}
@ -153,13 +156,14 @@ void WelcomeMode::networkResponseReady(QNetworkReply* reply)
if(reply != NULL)
{
QString version(reply->readAll());
QString trimmedVersion = version.trimmed();
version = version.trimmed();
reply->deleteLater();
m_d->networkAccess->deleteLater();
if(trimmedVersion != VersionInfo::tagOrHash8())
if(version != VersionInfo::tagOrHash8())
{
m_newVersionText = tr("(Update Available: %1) ").arg(trimmedVersion);
m_newVersionText = tr("(Update Available: %1)").arg(version);
emit newVersionTextChanged();
}
}