rooty/LibrePilot
1
0
Fork 0
mirror of https://bitbucket.org/librepilot/librepilot.git synced 2025-02-27 16:54:15 +01:00
Code Issues Releases Activity

OP-203 PIOS_USART: Don't disable interrupts for receive buffer since

Browse Source 
only one receive task.  This is less generally safe but decreases the
frequency of resets in our current configuration

git-svn-id: svn://svn.openpilot.org/OpenPilot/trunk@2144 ebee16cc-31ac-478f-84a7-5cbb03baadba
This commit is contained in:
peabody124 2010-11-23 17:13:49 +00:00 committed by peabody124
parent a454f06bf8
commit e89911bb8a
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
flight/PiOS/STM32F10x/pios_usart.c
View File

@ -208,9 +208,9 @@ int32_t PIOS_USART_RxBufferGet(uint8_t usart)
}
/* get byte - this operation should be atomic! */
PIOS_IRQ_Disable();
/* PIOS_IRQ_Disable(); -- not needed only one reader */
uint8_t b = fifoBuf_getByte(&usart_dev->rx);
PIOS_IRQ_Enable();
/* PIOS_IRQ_Enable(); */
/* Return received byte */
return b;
@ -242,9 +242,9 @@ int32_t PIOS_USART_RxBufferPeek(uint8_t usart)
}
/* get byte - this operation should be atomic! */
PIOS_IRQ_Disable();
/* PIOS_IRQ_Disable(); -- not needed only one reader */
uint8_t b = fifoBuf_getBytePeek(&usart_dev->rx);
PIOS_IRQ_Enable();
/* PIOS_IRQ_Enable(); */
/* Return received byte */
return b;
@ -278,9 +278,9 @@ int32_t PIOS_USART_RxBufferPut(uint8_t usart, uint8_t b)
/* Copy received byte into receive buffer */
/* This operation should be atomic! */
PIOS_IRQ_Disable();
/* PIOS_IRQ_Disable(); -- not needed only one reader */
fifoBuf_putByte(&usart_dev->rx,b);
PIOS_IRQ_Enable();
/* PIOS_IRQ_Enable(); */
/* No error */
return 0;
@ -356,9 +356,9 @@ int32_t PIOS_USART_TxBufferGet(uint8_t usart)
}
/* get byte - this operation should be atomic! */
PIOS_IRQ_Disable();
PIOS_IRQ_Disable();
uint8_t b = fifoBuf_getByte(&usart_dev->tx);
PIOS_IRQ_Enable();
PIOS_IRQ_Enable();
/* Return received byte */
return b;
@ -393,7 +393,8 @@ int32_t PIOS_USART_TxBufferPutMoreNonBlocking(uint8_t usart, const uint8_t * buf
}
/* Copy bytes to be transmitted into transmit buffer */
/* This operation should be atomic! */
/* This operation should be atomic! Can't rely on */
/* fifoBuf since two tasks write to the port */
PIOS_IRQ_Disable();
uint16_t used = fifoBuf_getUsed(&usart_dev->tx);
fifoBuf_putData(&usart_dev->tx,buffer,len);