rooty/LibrePilot
1
0
Fork 0
mirror of https://bitbucket.org/librepilot/librepilot.git synced 2025-01-29 14:52:12 +01:00
Code Issues Releases Activity

OP-326 Long I2C messages starve the other drivers

Browse Source 
We where hammered on the head with interrupts that the driver does not need, not allowing the ISRs of other drivers to run 

git-svn-id: svn://svn.openpilot.org/OpenPilot/trunk@3018 ebee16cc-31ac-478f-84a7-5cbb03baadba
This commit is contained in:
FredericG 2011-03-09 17:12:18 +00:00 committed by FredericG
parent 4c51e80b5b
commit fc18f1cb36
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
flight/PiOS/STM32F10x/pios_i2c.c
View File

@ -411,7 +411,14 @@ static void go_starting(struct pios_i2c_adapter *i2c_adapter)
i2c_adapter->last_byte = &(i2c_adapter->active_txn->buf[i2c_adapter->active_txn->len - 1]);
I2C_GenerateSTART(i2c_adapter->cfg->regs, ENABLE);
I2C_ITConfig(i2c_adapter->cfg->regs, I2C_IT_EVT | I2C_IT_BUF | I2C_IT_ERR, ENABLE);
if (i2c_adapter->active_txn->rw == PIOS_I2C_TXN_READ) {
I2C_ITConfig(i2c_adapter->cfg->regs, I2C_IT_EVT | I2C_IT_BUF | I2C_IT_ERR, ENABLE);
} else {
// For write operations, do not enable the IT_BUF events.
// The current driver does not act when the TX data register is not full, only when the complete byte is sent.
// With the IT_BUF enabled, we constantly get IRQs, See OP-326
I2C_ITConfig(i2c_adapter->cfg->regs, I2C_IT_EVT | I2C_IT_ERR, ENABLE);
}
}
/* Common to 'more' and 'last' transaction */
@ -1100,7 +1107,9 @@ void PIOS_I2C_ER_IRQ_Handler(uint32_t i2c_id)
if(event & I2C_FLAG_AF) {
i2c_nack_counter++;
I2C_ClearFlag(i2c_adapter->cfg->regs, I2C_FLAG_AF);
i2c_adapter_inject_event(i2c_adapter, I2C_EVENT_NACK);
} else { /* Mostly bus errors here */
i2c_adapter_log_fault(PIOS_I2C_ERROR_INTERRUPT);