1
0
mirror of https://bitbucket.org/librepilot/librepilot.git synced 2025-01-19 04:52:12 +01:00

26 Commits

Author SHA1 Message Date
chris pember
827b8b9486 added groupboxes to the pages that were loose 2012-10-06 11:43:03 -07:00
chris pember
c2641fd21d added scroll areas to all the preference settings screens 2012-10-06 01:55:24 -07:00
Dmytro Poplavskiy
d358591726 Fixed possible notification plugin deadlock
Protecting with mutex stateChanged(Phonon::State)
and starting/stopping playback looks dangerous,
the media player may emit another state change leading to deadlock.

The mutex should not be necessary here
since all the slots are executed in the main thread.

Changing the objectUpdated(UAVObject*) connection type
to Qt::QueuedConnection is not strictly necessary,
signals between threads are queued by default,
it serves more the documentation purpose.
2012-08-09 09:05:59 +10:00
Dmytro Poplavskiy
f4ff84d41a Notify plugin cleanup
Removed a few unused SoundNotifyPlugin members
2012-08-09 09:05:39 +10:00
PT_Dreamer
5f8c6dc7af Remove unwanted file 2012-07-28 19:06:54 +01:00
PT_Dreamer
ed92edc421 GCS - Should fix crashes when opening and closing settings page 2012-06-02 01:12:55 +01:00
David Ankers
6c030482a5 Fix 64 bit compile 2012-01-30 04:51:11 +11:00
Michael Rumpler
1b314ee256 * cleaned up notifyplugin
cause:
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifyplugin.cpp:104:6:
   warning: unused parameter ‘configInfo’ [-Wunused-parameter]
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifyplugin.cpp:353:6:
   warning: unused parameter ‘values’ [-Wunused-parameter]
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifypluginoptionspage.cpp:73:10:
   warning: unused parameter ‘parent’ [-Wunused-parameter]
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifypluginoptionspage.cpp:451:6:
   warning: unused parameter ‘rangeStr’ [-Wunused-parameter]
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifypluginoptionspage.cpp:512:7:
   warning: unused parameter ‘oldstate’ [-Wunused-parameter]
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifypluginoptionspage.cpp:527:6:
   warning: unused parameter ‘deselected’ [-Wunused-parameter]

   implemented solution:
   fixed all of them (commented out var name)

* fixed bug in check code

   cause:
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifyplugin.cpp:
   In member function ‘void SoundNotifyPlugin::checkNotificationRule(NotificationItem*, UAVObject*)’:
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifyplugin.cpp:398:109:
   warning: suggest parentheses around comparison in operand of ‘|’ [-Wparentheses]

   implemented solution:
   this is an obvious bug that is syntactically correct but leads to a
   warning with a good compiler so this bug can be found. fixed that to use
   logical or instead of bitwise or.

* fixed bug in include file (error in compilation under Linux)

   cause:
   In file included from
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifypluginoptionspage.cpp:47:0:
   /projects/OpenPilot/git/ground/openpilotgcs/src/plugins/notify/notifytablemodel.h:86:39:
   error: reference ‘_list’ cannot be declared ‘mutable’ [-fpermissive]

   implemented solution:
   removed the mutable flag, as this is wrongly used on a reference (and
   therefore correctly causing a compile-time error
2012-01-11 22:16:26 +01:00
zedamota
38392ee638 several fixes to the notify plugin 2012-01-09 16:09:50 +00:00
zedamota
9f2b71a351 Convert filename to lowercase 2012-01-09 14:06:27 +00:00
zedamota
f18c980c4e Small bug fix.
Added minus.wav witch is a copy of magic.was. "minus" file needed.
2011-12-06 13:13:20 +00:00
zedamota
b45044b8c3 Changed conditions base on strings to enums. 2011-12-06 09:59:28 +00:00
zedamota
78e25b1b8c Fixed conditions
Added support for negative values
Added support to "play once per update"
Added "never" rule for value sound
Several other bugfixes
2011-12-03 02:36:47 +00:00
Nickolay
20757c2efd +complete all features; +testing in progress; 2011-10-12 08:36:05 +03:00
Nickolay
6a5589ef51 +multiple selection with D&D completed; +support of enum and range for value completed; 2011-10-04 01:59:37 +03:00
Nickolay
82ec3199d7 +dynamic field UI; 2011-09-29 20:26:46 +03:00
Nickolay
1af42e1b32 + notify table reordering some changes 2011-09-19 00:30:57 +03:00
unknown
56e71cd82e +removed public members in notificationitem; +cosmetic changes; +fixed indentation; 2011-09-16 18:39:20 +03:00
Nickolay
c16e386e63 +reordering of table items - experimenting with D&D 2011-09-16 02:24:35 +03:00
Nickolay
e14e0a763b - temporary remove assert in finished callback; 2011-09-15 01:35:19 +03:00
Nickolay
3af398d7f9 initial changes 2011-09-15 00:38:18 +03:00
elafargue
c55602a466 OP-538 Included fixes into ground codebase, thanks. 2011-06-26 12:16:21 +02:00
Corvus Corax
bff970d414 GCS: notifyplugin: fix casing in phonon include to lower case. Qt ships phonon in lower case directory. 2011-05-05 19:37:23 +02:00
elafargue
30751b4eb2 OP-463 Fix Phonon includes for better cross platform compatibility. 2011-05-01 15:19:36 +02:00
erhard
311bcdd492 OP-232 gcs configuration: First step to configure all plugins in a standard way
git-svn-id: svn://svn.openpilot.org/OpenPilot/trunk@2632 ebee16cc-31ac-478f-84a7-5cbb03baadba
2011-01-30 23:22:51 +00:00
stac
7195862d77 build: Move openpilotgcs into its own subdirectory
This will allow us to build a parent project for
qt-creator that sits above both openpilotgcs and
uavobjgenerator so that we can build both projects
at the same time.

git-svn-id: svn://svn.openpilot.org/OpenPilot/trunk@2528 ebee16cc-31ac-478f-84a7-5cbb03baadba
2011-01-22 17:40:26 +00:00