rooty/OwncloudContactsOfficial
1
0
Fork 0
mirror of https://github.com/owncloudarchive/contacts.git synced 2025-01-30 19:52:17 +01:00
Code Issues Releases Activity

Contacts: Cache queries in Database backend.

Browse Source
This commit is contained in:
Thomas Tanghus 2013-03-13 05:19:38 +01:00
parent d9640bdc4e
commit 3b8cc18aff
1 changed files with 75 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

126
lib/backend/database.php
View File

@ -32,6 +32,7 @@ use Sabre\VObject\Reader;
class Database extends AbstractBackend { class Database extends AbstractBackend {
public $backendname = 'database'; public $backendname = 'database';
static private $preparedQueries = array();
/** /**
* Sets up the backend * Sets up the backend
@ -62,10 +63,12 @@ class Database extends AbstractBackend {
$userid = $userid ? $userid : $this->userid; $userid = $userid ? $userid : $this->userid;
try { try {
$stmt = \OCP\DB::prepare( 'SELECT * FROM `' if(!isset(self::$preparedQueries['addressbooksforuser'])) {
. $this->addressBooksTableName self::$preparedQueries['addressbooksforuser'] = \OCP\DB::prepare( 'SELECT * FROM `'
. '` WHERE `userid` = ? ORDER BY `displayname`' ); . $this->addressBooksTableName
$result = $stmt->execute(array($userid)); . '` WHERE `userid` = ? ORDER BY `displayname`' );
}
$result = self::$preparedQueries['addressbooksforuser']->execute(array($userid));
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OCP\Util::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR); \OCP\Util::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
return $this->addressbooks; return $this->addressbooks;
@ -96,10 +99,10 @@ class Database extends AbstractBackend {
try { try {
$query = 'SELECT * FROM `' . $this->addressBooksTableName $query = 'SELECT * FROM `' . $this->addressBooksTableName
. '` WHERE `id` = ?'; . '` WHERE `id` = ?';
//\OCP\Util::writeLog('contacts', __METHOD__.' query: ' if(!isset(self::$preparedQueries['getaddressbook'])) {
// . $query, \OCP\Util::DEBUG); self::$preparedQueries['getaddressbook'] = \OCP\DB::prepare($query);
$stmt = \OCP\DB::prepare($query); }
$result = $stmt->execute(array($addressbookid)); $result = self::$preparedQueries['getaddressbook']->execute(array($addressbookid));
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OCP\Util::write('contacts', __METHOD__. 'DB error: ' \OCP\Util::write('contacts', __METHOD__. 'DB error: '
. \OC_DB::getErrorMessage($result), \OCP\Util::ERROR); . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
@ -123,27 +126,7 @@ class Database extends AbstractBackend {
} }
return false; return false;
} }
try { return count($this->getAddressBook($addressbookid)) > 0;
$query = 'SELECT `id` FROM `' . $this->addressBooksTableName
. '` WHERE `id` = ?';
\OCP\Util::writeLog('contacts', __METHOD__.' query: '
. $query, \OCP\Util::DEBUG);
$stmt = \OCP\DB::prepare($query);
$result = $stmt->execute(array($addressbookid));
if (\OC_DB::isError($result)) {
\OCP\Util::write('contacts', __METHOD__. 'DB error: '
. \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
return false;
}
if($result->fetchOne()) {
return true;
}
} catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR);
return false;
}
return false;
} }
/** /**
@ -179,11 +162,15 @@ class Database extends AbstractBackend {
$stmt = \OCP\DB::prepare($query); $stmt = \OCP\DB::prepare($query);
$result = $stmt->execute($updates); $result = $stmt->execute($updates);
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OC_Log::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OC_Log::ERROR); \OC_Log::write('contacts',
__METHOD__. 'DB error: '
. \OC_DB::getErrorMessage($result), \OC_Log::ERROR);
return false; return false;
} }
} catch(Exception $e) { } catch(Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__ . ', exception: ' . $e->getMessage(), \OCP\Util::ERROR); \OCP\Util::writeLog('contacts',
__METHOD__ . ', exception: '
. $e->getMessage(), \OCP\Util::ERROR);
return false; return false;
} }
@ -217,8 +204,10 @@ class Database extends AbstractBackend {
$updates[] = isset($properties['description']) ? $properties['description'] : ''; $updates[] = isset($properties['description']) ? $properties['description'] : '';
try { try {
$stmt = \OCP\DB::prepare($query); if(!isset(self::$preparedQueries['createaddressbook'])) {
$result = $stmt->execute($updates); self::$preparedQueries['createaddressbook'] = \OCP\DB::prepare($query);
}
$result = self::$preparedQueries['createaddressbook']->execute($updates);
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OC_Log::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OC_Log::ERROR); \OC_Log::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OC_Log::ERROR);
return false; return false;
@ -242,18 +231,29 @@ class Database extends AbstractBackend {
array('id' => $addressbookid) array('id' => $addressbookid)
); );
$stmt = \OCP\DB::prepare('DELETE FROM `' . $this->cardsTableName . '` WHERE `addressbookid` = ?'); if(!isset(self::$preparedQueries['deleteaddressbookcontacts'])) {
self::$preparedQueries['deleteaddressbookcontacts'] =
\OCP\DB::prepare('DELETE FROM `'
. $this->cardsTableName
. '` WHERE `addressbookid` = ?');
}
try { try {
$stmt->execute(array($addressbookid)); self::$preparedQueries['deleteaddressbookcontacts']
->execute(array($addressbookid));
} catch(\Exception $e) { } catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__. \OCP\Util::writeLog('contacts', __METHOD__.
', exception: ' . $e->getMessage(), \OCP\Util::ERROR); ', exception: ' . $e->getMessage(), \OCP\Util::ERROR);
return false; return false;
} }
$stmt = \OCP\DB::prepare('DELETE FROM `' . $this->addressBooksTableName . '` WHERE `id` = ?'); if(!isset(self::$preparedQueries['deleteaddressbook'])) {
self::$preparedQueries['deleteaddressbook'] =
\OCP\DB::prepare('DELETE FROM `'
. $this->addressBooksTableName . '` WHERE `id` = ?');
}
try { try {
$stmt->execute(array($addressbookid)); self::$preparedQueries['deleteaddressbook']
->execute(array($addressbookid));
} catch(\Exception $e) { } catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__. \OCP\Util::writeLog('contacts', __METHOD__.
', exception: ' . $e->getMessage(), \OCP\Util::ERROR); ', exception: ' . $e->getMessage(), \OCP\Util::ERROR);
@ -269,8 +269,12 @@ class Database extends AbstractBackend {
* @return boolean * @return boolean
*/ */
public static function touchAddressBook($id) { public static function touchAddressBook($id) {
$stmt = \OCP\DB::prepare( 'UPDATE `' . $this->addressBooksTableName . '` SET `ctag` = `ctag` + 1 WHERE `id` = ?' ); $query = 'UPDATE `' . $this->addressBooksTableName
$stmt->execute(array($id)); . '` SET `ctag` = `ctag` + 1 WHERE `id` = ?';
if(!isset(self::$preparedQueries['touchaddressbook'])) {
self::$preparedQueries['touchaddressbook'] = \OCP\DB::prepare($query);
}
self::$preparedQueries['touchaddressbook']->execute(array($id));
return true; return true;
} }
@ -279,8 +283,10 @@ class Database extends AbstractBackend {
$sql = 'SELECT MAX(`lastmodified`) FROM `' . $this->cardsTableName . '`, `' . $this->addressBooksTableName . '` ' . $sql = 'SELECT MAX(`lastmodified`) FROM `' . $this->cardsTableName . '`, `' . $this->addressBooksTableName . '` ' .
'WHERE `' . $this->cardsTableName . '`.`addressbookid` = `*PREFIX*contacts_addressbooks`.`id` AND ' . 'WHERE `' . $this->cardsTableName . '`.`addressbookid` = `*PREFIX*contacts_addressbooks`.`id` AND ' .
'`' . $this->addressBooksTableName . '`.`userid` = ? AND `' . $this->addressBooksTableName . '`.`id` = ?'; '`' . $this->addressBooksTableName . '`.`userid` = ? AND `' . $this->addressBooksTableName . '`.`id` = ?';
$stmt = \OCP\DB::prepare($sql); if(!isset(self::$preparedQueries['lastmodifiedaddressbook'])) {
$result = $stmt->execute(array($this->userid, $addressbookid)); self::$preparedQueries['lastmodifiedaddressbook'] = \OCP\DB::prepare($sql);
}
$result = self::$preparedQueries['lastmodifiedaddressbook']->execute(array($this->userid, $addressbookid));
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OC_Log::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OC_Log::ERROR); \OC_Log::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OC_Log::ERROR);
return null; return null;
@ -396,10 +402,14 @@ class Database extends AbstractBackend {
$contact->REV = $now->format(\DateTime::W3C); $contact->REV = $now->format(\DateTime::W3C);
$data = $contact->serialize(); $data = $contact->serialize();
$stmt = \OCP\DB::prepare('INSERT INTO `' if(!isset(self::$preparedQueries['createaddressbook'])) {
. $this->cardsTableName . '` (`addressbookid`,`fullname`,`carddata`,`uri`,`lastmodified`) VALUES(?,?,?,?,?)' ); self::$preparedQueries['createaddressbook'] = \OCP\DB::prepare('INSERT INTO `'
. $this->cardsTableName
. '` (`addressbookid`,`fullname`,`carddata`,`uri`,`lastmodified`) VALUES(?,?,?,?,?)' );
}
try { try {
$result = $stmt->execute(array($addressbookid, (string)$contact->FN, $contact->serialize(), $uri, time())); $result = self::$preparedQueries['createaddressbook']
->execute(array($addressbookid, (string)$contact->FN, $contact->serialize(), $uri, time()));
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OC_Log::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR); \OC_Log::write('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
return false; return false;
@ -440,23 +450,30 @@ class Database extends AbstractBackend {
$where_query = ''; $where_query = '';
if(isset($id['id'])) { if(isset($id['id'])) {
$id = $id['id']; $id = $id['id'];
$qname = 'createcontactbyid';
} elseif(isset($id['uri'])) { } elseif(isset($id['uri'])) {
$where_query = '`id` = ?'; $where_query = '`id` = ?';
$id = $id['uri']; $id = $id['uri'];
$qname = 'createcontactbyuri';
} else { } else {
throw new Exception( throw new Exception(
__METHOD__ . ' If second argument is an array, either \'id\' or \'uri\' has to be set.' __METHOD__ . ' If second argument is an array, either \'id\' or \'uri\' has to be set.'
); );
} }
} else {
$qname = 'createcontactbyid';
} }
$now = new \DateTime; $now = new \DateTime;
$contact->REV = $now->format(\DateTime::W3C); $contact->REV = $now->format(\DateTime::W3C);
$data = $card->serialize(); $data = $card->serialize();
$stmt = \OCP\DB::prepare( 'UPDATE `' . $this->cardsTableName $query = 'UPDATE `' . $this->cardsTableName
. '` SET `fullname` = ?,`carddata` = ?, `lastmodified` = ? WHERE ' . $where_query ); . '` SET `fullname` = ?,`carddata` = ?, `lastmodified` = ? WHERE ' . $where_query;
if(!isset(self::$preparedQueries[$qname])) {
self::$preparedQueries[$qname] = \OCP\DB::prepare($query);
}
try { try {
$result = $stmt->execute(array($contact->FN, $data, time(), $id)); $result = self::$preparedQueries[$qname]->execute(array($contact->FN, $data, time(), $id));
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OCP\Util::writeLog('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR); \OCP\Util::writeLog('contacts', __METHOD__. 'DB error: ' . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
return false; return false;
@ -489,22 +506,29 @@ class Database extends AbstractBackend {
$where_query = ''; $where_query = '';
if(isset($id['id'])) { if(isset($id['id'])) {
$id = $id['id']; $id = $id['id'];
$qname = 'deletecontactsbyid';
} elseif(isset($id['uri'])) { } elseif(isset($id['uri'])) {
$where_query = '`id` = ?'; $where_query = '`id` = ?';
$id = $id['uri']; $id = $id['uri'];
$qname = 'deletecontactsbyuri';
} else { } else {
throw new Exception( throw new Exception(
__METHOD__ . ' If second argument is an array, either \'id\' or \'uri\' has to be set.' __METHOD__ . ' If second argument is an array, either \'id\' or \'uri\' has to be set.'
); );
} }
} else {
$qname = 'deletecontactsbyid';
} }
\OC_Hook::emit('\OCA\Contacts\VCard', 'pre_deleteContact', \OC_Hook::emit('\OCA\Contacts\VCard', 'pre_deleteContact',
array('id' => $id) array('id' => $id)
); );
$stmt = \OCP\DB::prepare('DELETE FROM `' . $this->cardsTableName if(!isset(self::$preparedQueries[$qname])) {
. '` WHERE ' . $where_query . ' AND `addressbookid` = ?'); self::$preparedQueries[$qname] = \OCP\DB::prepare('DELETE FROM `'
. $this->cardsTableName
. '` WHERE ' . $where_query . ' AND `addressbookid` = ?');
}
try { try {
$stmt->execute(array($id, $addressbookid)); self::$preparedQueries[$qname]->execute(array($id, $addressbookid));
if (\OC_DB::isError($result)) { if (\OC_DB::isError($result)) {
\OCP\Util::writeLog('contacts', __METHOD__. 'DB error: ' \OCP\Util::writeLog('contacts', __METHOD__. 'DB error: '
. \OC_DB::getErrorMessage($result), \OCP\Util::ERROR); . \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
@ -550,4 +574,4 @@ class Database extends AbstractBackend {
public function lastModifiedContact($addressbookid, $id) { public function lastModifiedContact($addressbookid, $id) {
} }
} }