rooty/OwncloudContactsOfficial
1
0
Fork 0
mirror of https://github.com/owncloudarchive/contacts.git synced 2025-01-18 07:52:21 +01:00
Code Issues Releases Activity

Check if querys succeeded

Browse Source
This commit is contained in:
LEDfan 2014-04-01 21:25:41 +02:00
parent 8362ef1c99
commit ab03ba5ff2
1 changed files with 75 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

115
lib/backend/owncloudusers.php
View File

@ -98,9 +98,9 @@ class OwnCloudUsers extends AbstractBackend {
return array(); return array();
} }
} catch(\Exception $e) { } catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: ' \OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR); . $e->getMessage(), \OCP\Util::ERROR);
return $this->addressBooks; return array();
} }
return $this->getAddressBooksForUser(); return $this->getAddressBooksForUser();
@ -131,13 +131,13 @@ class OwnCloudUsers extends AbstractBackend {
// TODO create address book if it doesn't exists // TODO create address book if it doesn't exists
$row['permissions'] = \OCP\PERMISSION_ALL; $row['permissions'] = \OCP\PERMISSION_ALL;
$row['backend'] = $this->name; $row['backend'] = $this->name;
return array($row);
} }
} catch(\Exception $e) { } catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: ' \OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR); . $e->getMessage(), \OCP\Util::ERROR);
return $this->addressBooks; return array();
} }
return array($row);
} }
/** /**
@ -191,7 +191,7 @@ class OwnCloudUsers extends AbstractBackend {
} catch(\Exception $e) { } catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: ' \OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR); . $e->getMessage(), \OCP\Util::ERROR);
return $this->addressBooks; return array();
} }
} }
@ -221,7 +221,7 @@ class OwnCloudUsers extends AbstractBackend {
} catch(\Exception $e) { } catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: ' \OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR); . $e->getMessage(), \OCP\Util::ERROR);
return $this->addressBooks; return array();
} }
} }
@ -239,7 +239,8 @@ class OwnCloudUsers extends AbstractBackend {
*/ */
private function addContacts($contacts, $addressbookid){ private function addContacts($contacts, $addressbookid){
foreach($contacts as $user){ foreach($contacts as $user){
$sql = 'INSERT INTO ' . $this->cardsTableName . ' (' try{
$sql = 'INSERT INTO ' . $this->cardsTableName . ' ('
. 'id, ' . 'id, '
. 'owner,' . 'owner,'
. 'addressbookid, ' . 'addressbookid, '
@ -257,24 +258,35 @@ class OwnCloudUsers extends AbstractBackend {
. '?' . '?'
. ')'; . ')';
$query = \OCP\DB::prepare($sql); $query = \OCP\DB::prepare($sql);
$contact = new Contact( $contact = new Contact(
$addressBook = new AddressBook($this , $this->getAddressBooksForUser()), // since there is only one addressbook with OC users for each OC user we can use this function $addressBook = new AddressBook($this , $this->getAddressBooksForUser()), // since there is only one addressbook with OC users for each OC user we can use this function
$this, $this,
array( array(
"id" => $user, "id" => $user,
"lastmodified" => time(), "lastmodified" => time(),
"displayname" => \OCP\User::getDisplayName($user), "displayname" => \OCP\User::getDisplayName($user),
"fullname" => \OCP\User::getDisplayName($user) "fullname" => \OCP\User::getDisplayName($user)
) )
); );
$carddata = $this->generateCardData($contact); $carddata = $this->generateCardData($contact);
$result = $query->execute(array($user, $this->userid, $addressbookid, \OCP\User::getDisplayName($user), $carddata->serialize(), 'test', time())); $result = $query->execute(array($user, $this->userid, $addressbookid, \OCP\User::getDisplayName($user), $carddata->serialize(), 'test', time()));
// TODO Check if $result succeeded
if (\OCP\DB::isError($result)) {
\OCP\Util::writeLog('contacts', __METHOD__. 'DB error: '
. \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
return false;
} else {
return true;
}
} catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR);
return false;
}
} }
} }
/** /**
* Help function to remove contacts from an addressbook. * Help function to remove contacts from an addressbook.
* This only happens when an admin remove an ownCloud user * This only happens when an admin remove an ownCloud user
@ -284,11 +296,22 @@ class OwnCloudUsers extends AbstractBackend {
*/ */
private function removeContacts($contacts, $addressbookid){ private function removeContacts($contacts, $addressbookid){
foreach($contacts as $user){ foreach($contacts as $user){
$sql = 'DELETE FROM ' . $this->cardsTableName . ' WHERE owner = ? AND id = ?'; try{
$sql = 'DELETE FROM ' . $this->cardsTableName . ' WHERE owner = ? AND id = ?';
$query = \OCP\DB::prepare($sql); $query = \OCP\DB::prepare($sql);
$result = $query->execute(array($this->userid, $user)); $result = $query->execute(array($this->userid, $user));
// TODO Check if $result succeeded if (\OCP\DB::isError($result)) {
\OCP\Util::writeLog('contacts', __METHOD__. 'DB error: '
. \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
return false;
} else {
return true;
}
} catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR);
return false;
}
} }
} }
@ -369,18 +392,30 @@ class OwnCloudUsers extends AbstractBackend {
} }
$data = $contact->serialize(); $data = $contact->serialize();
$sql = 'UPDATE ' . $this->cardsTableName try{
. ' SET ' $sql = 'UPDATE ' . $this->cardsTableName
. ' SET '
. '`addressbookid` = ?, ' . '`addressbookid` = ?, '
. '`fullname` = ?, ' . '`fullname` = ?, '
. '`carddata` = ?, ' . '`carddata` = ?, '
. '`lastmodified` = ? ' . '`lastmodified` = ? '
. ' WHERE ' . ' WHERE '
. '`id` = ? ' . '`id` = ? '
. 'AND `owner` = ? '; . 'AND `owner` = ? ';
$query = \OCP\DB::prepare($sql); $query = \OCP\DB::prepare($sql);
$result = $query->execute(array($addressBookId, $contact->FN, $data, time(), $id, $this->userid)); $result = $query->execute(array($addressBookId, $contact->FN, $data, time(), $id, $this->userid));
return true; if (\OCP\DB::isError($result)) {
\OCP\Util::writeLog('contacts', __METHOD__. 'DB error: '
. \OC_DB::getErrorMessage($result), \OCP\Util::ERROR);
return false;
} else {
return true;
}
} catch(\Exception $e) {
\OCP\Util::writeLog('contacts', __METHOD__.' exception: '
. $e->getMessage(), \OCP\Util::ERROR);
return false;
}
} }
} }