rooty/PiBits
1
0
Fork 0
mirror of https://github.com/richardghirst/PiBits.git synced 2025-02-26 19:54:16 +01:00
Code Issues Releases Activity

Refactor dev_write prior to allowing it to take partial strings.

Browse Source
This commit is contained in:
Robin Mallinson 2012-11-18 21:52:28 +00:00
parent e993a088eb
commit b14044eba1
2 changed files with 37 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ServoBlaster/servoblaster.c
View File

@ -403,18 +403,21 @@ static ssize_t dev_read(struct file *filp,char *buf,size_t count,loff_t *f_pos)
} }
static ssize_t dev_write(struct file *filp,const char *buf,size_t count,loff_t *f_pos) static ssize_t dev_write(struct file *filp,const char *buf,size_t count,loff_t *f_pos)
{
char str[32];
if (count > 31) count = 31;
if (copy_from_user(str, buf, count)) {
return -EFAULT;
}
str[count] = '\0';
// Process the complete user string.
{ {
int servo; int servo;
int cnt; int cnt;
int n; int n;
char str[32];
char dummy; char dummy;
cnt = count < 32 ? count : 31;
if (copy_from_user(str, buf, cnt)) {
return -EFAULT;
}
str[cnt] = '\0';
n = sscanf(str, "%d=%d\n%c", &servo, &cnt, &dummy); n = sscanf(str, "%d=%d\n%c", &servo, &cnt, &dummy);
if (n != 2) { if (n != 2) {
printk(KERN_WARNING "ServoBlaster: Failed to parse command (n=%d)\n", n); printk(KERN_WARNING "ServoBlaster: Failed to parse command (n=%d)\n", n);
@ -443,6 +446,7 @@ static ssize_t dev_write(struct file *filp,const char *buf,size_t count,loff_t *
} }
written_data[servo] = cnt; // Record data for use by dev_read written_data[servo] = cnt; // Record data for use by dev_read
local_irq_enable(); local_irq_enable();
}
return count; return count;
} }

BIN
ServoBlaster/servoblaster.ko
View File

Binary file not shown.