rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-02-20 19:54:19 +01:00
Code Issues Projects Releases Wiki Activity

Micro-optimize locking in fences

Browse Source 
When a fence has been missed, we can avoid locking *most* of the time
via the double-checked locking pattern. We still lock before a second
check in case the scheduler caused us to miss the fence. If the
scheduler did cause us to miss the fence, we can drop the lock prior to
executing the callback function, as a second micro-optimization.

Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
This commit is contained in:
Richard Yao 2024-01-10 22:43:42 -05:00 committed by Philip Rebohle
parent 854e06d3f0
commit 14560600a9
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/util/sync/sync_signal.h
View File

@ -137,14 +137,22 @@ namespace dxvk::sync {
template<typename Fn>
void setCallback(uint64_t value, Fn&& proc) {
if (value <= this->value()) {
proc();
return;
}
std::unique_lock<dxvk::mutex> lock(m_mutex);
// Verify value is still in the future upon lock.
if (value > this->value())
m_callbacks.emplace_back(std::piecewise_construct,
std::make_tuple(value),
std::make_tuple(proc));
else
else {
lock.unlock();
proc();
}
}
private: