rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-01-31 14:52:11 +01:00
Code Issues Projects Releases Wiki Activity

[dxvk] Clarify feature enablement

Browse Source 
And fall back to robustImageAccess if robustImageAccess2 is not supported.
Not what we want, but better than nothing.
This commit is contained in:
Philip Rebohle 2022-07-19 19:08:58 +02:00
parent fc796abede
commit 2d93760002
No known key found for this signature in database
GPG Key ID: C8CC613427A31C99
1 changed files with 31 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/dxvk/dxvk_adapter.cpp
View File

@ -333,24 +333,48 @@ namespace dxvk {
extensionsEnabled.merge(m_extraExtensions);
DxvkNameList extensionNameList = extensionsEnabled.toNameList();
// Enable additional device features if supported
enabledFeatures.vk12.drawIndirectCount = m_deviceFeatures.vk12.drawIndirectCount;
enabledFeatures.vk12.hostQueryReset = VK_TRUE;
enabledFeatures.vk12.shaderOutputViewportIndex = m_deviceFeatures.vk12.shaderOutputViewportIndex;
enabledFeatures.vk12.shaderOutputLayer = m_deviceFeatures.vk12.shaderOutputLayer;
// Optionally used by some client API extensions
enabledFeatures.vk12.drawIndirectCount =
m_deviceFeatures.vk12.drawIndirectCount;
enabledFeatures.vk13.pipelineCreationCacheControl = m_deviceFeatures.vk13.pipelineCreationCacheControl;
// Required since we no longer have a fallback for GPU queries
enabledFeatures.vk12.hostQueryReset = VK_TRUE;
// Used by some internal shaders, and can be used by applications
enabledFeatures.vk12.shaderOutputViewportIndex =
m_deviceFeatures.vk12.shaderOutputViewportIndex;
enabledFeatures.vk12.shaderOutputLayer =
m_deviceFeatures.vk12.shaderOutputLayer;
// Only enable the base image robustness feature if robustness 2 isn't
// supported, since this is only a subset of what we actually want.
enabledFeatures.vk13.robustImageAccess =
m_deviceFeatures.vk13.robustImageAccess &&
!m_deviceFeatures.extRobustness2.robustImageAccess2;
// Only used in combination with pipeline libraries
// right now, but enabling it won't hurt anyway
enabledFeatures.vk13.pipelineCreationCacheControl =
m_deviceFeatures.vk13.pipelineCreationCacheControl;
// Core features that we're relying on in various places
enabledFeatures.vk13.synchronization2 = VK_TRUE;
enabledFeatures.vk13.dynamicRendering = VK_TRUE;
enabledFeatures.vk13.maintenance4 = VK_TRUE;
// Used for both pNext shader module info, and fast-linking pipelines provided
// that graphicsPipelineLibraryIndependentInterpolationDecoration is supported
enabledFeatures.extGraphicsPipelineLibrary.graphicsPipelineLibrary =
m_deviceFeatures.extGraphicsPipelineLibrary.graphicsPipelineLibrary;
// Require robustBufferAccess2 since we use the robustness alignment
// info in a number of places, and require null descriptor support
// since we no longer have a fallback for those in the backend
enabledFeatures.extRobustness2.robustBufferAccess2 = VK_TRUE;
enabledFeatures.extRobustness2.robustImageAccess2 = m_deviceFeatures.extRobustness2.robustImageAccess2;
enabledFeatures.extRobustness2.nullDescriptor = VK_TRUE;
// We use this to avoid decompressing SPIR-V shaders in some situations
enabledFeatures.extShaderModuleIdentifier.shaderModuleIdentifier =
m_deviceFeatures.extShaderModuleIdentifier.shaderModuleIdentifier;
@ -775,6 +799,7 @@ namespace dxvk {
"\n shaderOutputViewportIndex : ", features.vk12.shaderOutputViewportIndex,
"\n shaderOutputLayer : ", features.vk12.shaderOutputLayer,
"\nVulkan 1.3",
"\n robustImageAccess : ", features.vk13.robustImageAccess,
"\n pipelineCreationCacheControl : ", features.vk13.pipelineCreationCacheControl,
"\n shaderDemoteToHelperInvocation : ", features.vk13.shaderDemoteToHelperInvocation,
"\n shaderZeroInitializeWorkgroupMemory : ", features.vk13.shaderZeroInitializeWorkgroupMemory,