rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-02-20 19:54:19 +01:00
Code Issues Projects Releases Wiki Activity

[dxvk] Tweak memory allocation behaviour on mapped memory types

Browse Source
This commit is contained in:
Philip Rebohle 2024-09-23 23:38:18 +02:00 committed by Philip Rebohle
parent 5c8728abd2
commit 3cd7e3efb5
2 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/dxvk/dxvk_memory.cpp
View File

@ -209,7 +209,16 @@ namespace dxvk {
// If the allocation is very large, use a dedicated allocation instead
// of creating a new chunk. This way we avoid excessive fragmentation,
// especially when a multiple such resources are created at once.
if (size * MinResourcesPerChunk > selectedPool.maxChunkSize) {
uint32_t minResourcesPerChunk = (properties & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) ? 1u : 4u;
// If we're on a mapped memory type and we're about to lose an entire chunk
// worth of memory to huge resources causing fragmentation, use dedicated
// allocations anyway and hope that the app doesn't do this every frame.
if (minResourcesPerChunk == 1u && size > selectedPool.maxChunkSize / 2u
&& type.stats.memoryAllocated - type.stats.memoryUsed + selectedPool.maxChunkSize - size >= selectedPool.maxChunkSize)
minResourcesPerChunk = 2u;
if (size * minResourcesPerChunk > selectedPool.maxChunkSize) {
DxvkDeviceMemory memory = allocateDeviceMemory(type, requirements.size, nullptr);
if (!memory.memory)
@ -223,7 +232,7 @@ namespace dxvk {
// multiple resources of the type we're tying to allocate.
VkDeviceSize desiredSize = selectedPool.nextChunkSize;
while (desiredSize < size * MinResourcesPerChunk)
while (desiredSize < size * minResourcesPerChunk)
desiredSize *= 2u;
if (allocateChunkInPool(type, selectedPool, properties, size, desiredSize)) {
@ -484,14 +493,13 @@ namespace dxvk {
VkDeviceSize allocationSize,
high_resolution_clock::time_point time) {
// Allow for one unused max-size chunk on device-local memory types.
// For system memory allocations, we need to be more lenient since
// applications will frequently allocate staging buffers.
// For mapped memory allocations, we need to be more lenient since
// applications will frequently allocate staging buffers or dynamic
// resources.
VkDeviceSize maxUnusedMemory = pool.maxChunkSize;
if (!(type.properties.propertyFlags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT)
&& (type.properties.propertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT)
&& (&pool == &type.mappedPool))
maxUnusedMemory *= env::is32BitHostPlatform() ? 2u : 4u;
if (&pool == &type.mappedPool)
maxUnusedMemory *= 4u;
// Factor current memory allocation into the decision to free chunks
VkDeviceSize heapBudget = (type.heap->properties.size * 4) / 5;

2
src/dxvk/dxvk_memory.h
View File

@ -335,8 +335,6 @@ namespace dxvk {
constexpr static VkDeviceSize MinChunkSize = 4ull << 20;
constexpr static VkDeviceSize MaxChunkSize = 256ull << 20;
constexpr static VkDeviceSize MinResourcesPerChunk = 4u;
public:
DxvkMemoryAllocator(DxvkDevice* device);