rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-04-05 16:40:17 +02:00
Code Issues Projects Releases Wiki Activity

[dxvk] Clean up DxvkImage::canShareImage

Browse Source
This commit is contained in:
Philip Rebohle 2022-09-11 15:32:16 +02:00
parent 0123e844b2
commit 443cb658f7
1 changed files with 23 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
src/dxvk/dxvk_image.cpp
View File

@ -187,45 +187,34 @@ namespace dxvk {
return false; return false;
} }
if (createInfo.flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) if (createInfo.flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) {
return false; Logger::err("Failed to create shared resource: Sharing sparse resources not supported");
VkPhysicalDeviceExternalImageFormatInfo externalImageFormatInfo = { VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_EXTERNAL_IMAGE_FORMAT_INFO };
externalImageFormatInfo.handleType = sharingInfo.type;
VkPhysicalDeviceImageFormatInfo2 imageFormatInfo = { VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGE_FORMAT_INFO_2, &externalImageFormatInfo };
imageFormatInfo.format = createInfo.format;
imageFormatInfo.type = createInfo.imageType;
imageFormatInfo.tiling = createInfo.tiling;
imageFormatInfo.usage = createInfo.usage;
imageFormatInfo.flags = createInfo.flags;
VkExternalImageFormatProperties externalImageFormatProperties = { VK_STRUCTURE_TYPE_EXTERNAL_IMAGE_FORMAT_PROPERTIES };
VkImageFormatProperties2 imageFormatProperties = { VK_STRUCTURE_TYPE_IMAGE_FORMAT_PROPERTIES_2, &externalImageFormatProperties };
VkResult vr = m_device->adapter()->vki()->vkGetPhysicalDeviceImageFormatProperties2(
m_device->adapter()->handle(), &imageFormatInfo, &imageFormatProperties);
if (vr != VK_SUCCESS) {
Logger::err(str::format("Failed to create shared resource: getImageProperties failed:", vr));
return false; return false;
} }
if (sharingInfo.mode == DxvkSharedHandleMode::Export) { DxvkFormatQuery formatQuery = { };
bool ret = externalImageFormatProperties.externalMemoryProperties.externalMemoryFeatures & VK_EXTERNAL_MEMORY_FEATURE_EXPORTABLE_BIT; formatQuery.format = createInfo.format;
if (!ret) formatQuery.type = createInfo.imageType;
Logger::err("Failed to create shared resource: image cannot be exported"); formatQuery.tiling = createInfo.tiling;
return ret; formatQuery.usage = createInfo.usage;
formatQuery.flags = createInfo.flags;
formatQuery.handleType = sharingInfo.type;
auto limits = m_device->getFormatLimits(formatQuery);
if (!limits)
return false;
VkExternalMemoryFeatureFlagBits requiredFeature = sharingInfo.mode == DxvkSharedHandleMode::Export
? VK_EXTERNAL_MEMORY_FEATURE_EXPORTABLE_BIT
: VK_EXTERNAL_MEMORY_FEATURE_IMPORTABLE_BIT;
if (!(limits->externalFeatures & requiredFeature)) {
Logger::err("Failed to create shared resource: Image cannot be shared");
return false;
} }
if (sharingInfo.mode == DxvkSharedHandleMode::Import) { return true;
bool ret = externalImageFormatProperties.externalMemoryProperties.externalMemoryFeatures & VK_EXTERNAL_MEMORY_FEATURE_IMPORTABLE_BIT;
if (!ret)
Logger::err("Failed to create shared resource: image cannot be imported");
return ret;
}
return false;
} }