From 4a74cd45d5385cb8e2ee4b2558ef5f3f622626c3 Mon Sep 17 00:00:00 2001 From: pchome Date: Sat, 28 Apr 2018 15:13:23 +0300 Subject: [PATCH] [clang-tidy] performance-move-const-arg fix (#324) https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html --- src/d3d11/d3d11_context.cpp | 2 +- src/d3d11/d3d11_device.cpp | 12 ++++++------ src/d3d11/d3d11_shader.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/d3d11/d3d11_context.cpp b/src/d3d11/d3d11_context.cpp index 8ad8a0b58..c1c0ac7bd 100644 --- a/src/d3d11/d3d11_context.cpp +++ b/src/d3d11/d3d11_context.cpp @@ -2604,7 +2604,7 @@ namespace dxvk { } // Create and bind the framebuffer object to the context - EmitCs([cAttachments = std::move(attachments)] (DxvkContext* ctx) { + EmitCs([cAttachments = attachments] (DxvkContext* ctx) { ctx->bindRenderTargets(cAttachments); }); } diff --git a/src/d3d11/d3d11_device.cpp b/src/d3d11/d3d11_device.cpp index aab795bd5..f36f5a9d6 100644 --- a/src/d3d11/d3d11_device.cpp +++ b/src/d3d11/d3d11_device.cpp @@ -1032,7 +1032,7 @@ namespace dxvk { return S_FALSE; *ppVertexShader = ref(new D3D11VertexShader( - this, std::move(module))); + this, module)); return S_OK; } @@ -1054,7 +1054,7 @@ namespace dxvk { return S_FALSE; *ppGeometryShader = ref(new D3D11GeometryShader( - this, std::move(module))); + this, module)); return S_OK; } @@ -1092,7 +1092,7 @@ namespace dxvk { return S_FALSE; *ppPixelShader = ref(new D3D11PixelShader( - this, std::move(module))); + this, module)); return S_OK; } @@ -1114,7 +1114,7 @@ namespace dxvk { return S_FALSE; *ppHullShader = ref(new D3D11HullShader( - this, std::move(module))); + this, module)); return S_OK; } @@ -1136,7 +1136,7 @@ namespace dxvk { return S_FALSE; *ppDomainShader = ref(new D3D11DomainShader( - this, std::move(module))); + this, module)); return S_OK; } @@ -1158,7 +1158,7 @@ namespace dxvk { return S_FALSE; *ppComputeShader = ref(new D3D11ComputeShader( - this, std::move(module))); + this, module)); return S_OK; } diff --git a/src/d3d11/d3d11_shader.h b/src/d3d11/d3d11_shader.h index 6483b16ab..5679fd9aa 100644 --- a/src/d3d11/d3d11_shader.h +++ b/src/d3d11/d3d11_shader.h @@ -104,7 +104,7 @@ namespace dxvk { public: D3D11Shader(D3D11Device* device, const D3D11ShaderModule& module) - : m_device(device), m_module(std::move(module)) { } + : m_device(device), m_module(module) { } ~D3D11Shader() { }