rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-01-30 20:52:11 +01:00
Code Issues Projects Releases Wiki Activity

[dxbc] Remove dxvk.useEarlyDiscard option

Browse Source 
No longer relevant on drivers that support DemoteToHelperInvocation.
Closes #2109.
This commit is contained in:
Philip Rebohle 2021-06-18 15:43:24 +02:00
parent 6b8ab4fd38
commit 7beb344f6f
No known key found for this signature in database
GPG Key ID: C8CC613427A31C99
5 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
dxvk.conf
View File

@ -217,21 +217,6 @@
# dxvk.useRawSsbo = Auto # dxvk.useRawSsbo = Auto
# Toggles early discard.
#
# Uses subgroup operations to determine whether it is safe to
# discard fragments before the end of a fragment shader. This
# is enabled by default on all drivers except RADV and Nvidia.
# Enabling this may improve or degrade performance depending
# on the game and hardware, or cause other issues.
#
# Supported values:
# - Auto: Don't change the default
# - True, False: Always enable / disable
# dxvk.useEarlyDiscard = Auto
# Controls workaround for NVIDIA HVV Heap bug. # Controls workaround for NVIDIA HVV Heap bug.
# #
# Limits the budget of NVIDIA's HVV (host-visible, # Limits the budget of NVIDIA's HVV (host-visible,

5
src/dxbc/dxbc_options.cpp
View File

@ -43,7 +43,7 @@ namespace dxvk {
forceTgsmBarriers = options.forceTgsmBarriers; forceTgsmBarriers = options.forceTgsmBarriers;
dynamicIndexedConstantBufferAsSsbo = options.constantBufferRangeCheck; dynamicIndexedConstantBufferAsSsbo = options.constantBufferRangeCheck;
// Disable early discard on Nvidia because it may hurt performance // Disable subgroup early discard on Nvidia because it may hurt performance
if (adapter->matchesDriver(DxvkGpuVendor::Nvidia, VK_DRIVER_ID_NVIDIA_PROPRIETARY_KHR, 0, 0)) if (adapter->matchesDriver(DxvkGpuVendor::Nvidia, VK_DRIVER_ID_NVIDIA_PROPRIETARY_KHR, 0, 0))
useSubgroupOpsForEarlyDiscard = false; useSubgroupOpsForEarlyDiscard = false;
@ -51,9 +51,6 @@ namespace dxvk {
if (adapter->matchesDriver(DxvkGpuVendor::Amd, VK_DRIVER_ID_MESA_RADV_KHR, 0, VK_MAKE_VERSION(19, 1, 0))) if (adapter->matchesDriver(DxvkGpuVendor::Amd, VK_DRIVER_ID_MESA_RADV_KHR, 0, VK_MAKE_VERSION(19, 1, 0)))
useSubgroupOpsForAtomicCounters = false; useSubgroupOpsForAtomicCounters = false;
// Apply shader-related options
applyTristate(useSubgroupOpsForEarlyDiscard, device->config().useEarlyDiscard);
// Figure out float control flags to match D3D11 rules // Figure out float control flags to match D3D11 rules
if (options.floatControls) { if (options.floatControls) {
if (devInfo.khrShaderFloatControls.shaderSignedZeroInfNanPreserveFloat32) if (devInfo.khrShaderFloatControls.shaderSignedZeroInfNanPreserveFloat32)

2
src/dxso/dxso_options.cpp
View File

@ -27,8 +27,6 @@ namespace dxvk {
useSubgroupOpsForEarlyDiscard = false; useSubgroupOpsForEarlyDiscard = false;
// Apply shader-related options // Apply shader-related options
applyTristate(useSubgroupOpsForEarlyDiscard, device->config().useEarlyDiscard);
strictConstantCopies = options.strictConstantCopies; strictConstantCopies = options.strictConstantCopies;
strictPow = options.strictPow; strictPow = options.strictPow;

1
src/dxvk/dxvk_options.cpp
View File

@ -8,7 +8,6 @@ namespace dxvk {
enableOpenXR = config.getOption<bool> ("dxvk.enableOpenXR", true); enableOpenXR = config.getOption<bool> ("dxvk.enableOpenXR", true);
numCompilerThreads = config.getOption<int32_t> ("dxvk.numCompilerThreads", 0); numCompilerThreads = config.getOption<int32_t> ("dxvk.numCompilerThreads", 0);
useRawSsbo = config.getOption<Tristate>("dxvk.useRawSsbo", Tristate::Auto); useRawSsbo = config.getOption<Tristate>("dxvk.useRawSsbo", Tristate::Auto);
useEarlyDiscard = config.getOption<Tristate>("dxvk.useEarlyDiscard", Tristate::Auto);
halveNvidiaHVVHeap = config.getOption<Tristate>("dxvk.halveNvidiaHVVHeap", Tristate::Auto); halveNvidiaHVVHeap = config.getOption<Tristate>("dxvk.halveNvidiaHVVHeap", Tristate::Auto);
hud = config.getOption<std::string>("dxvk.hud", ""); hud = config.getOption<std::string>("dxvk.hud", "");
} }

1
src/dxvk/dxvk_options.h
View File

@ -23,7 +23,6 @@ namespace dxvk {
/// Shader-related options /// Shader-related options
Tristate useRawSsbo; Tristate useRawSsbo;
Tristate useEarlyDiscard;
/// Workaround for NVIDIA driver /// Workaround for NVIDIA driver
/// bug 3114283. Cut usable HVV /// bug 3114283. Cut usable HVV