rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-04-01 09:25:24 +02:00
Code Issues Projects Releases Wiki Activity

[dxvk] Don't create shader modules for regular pipelines

Browse Source
This commit is contained in:
Philip Rebohle 2025-03-23 22:25:54 +01:00
parent 8ca0592017
commit 916a024fdc
1 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/dxvk/dxvk_shader.cpp
View File

@ -1150,31 +1150,14 @@ namespace dxvk {
auto& codeBuffer = m_codeBuffers[m_stageCount]; auto& codeBuffer = m_codeBuffers[m_stageCount];
codeBuffer = std::move(code); codeBuffer = std::move(code);
// For graphics pipelines, as long as graphics pipeline libraries are
// enabled, we do not need to create a shader module object and can
// instead chain the create info to the shader stage info struct.
auto& moduleInfo = m_moduleInfos[m_stageCount].moduleInfo; auto& moduleInfo = m_moduleInfos[m_stageCount].moduleInfo;
moduleInfo = { VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO }; moduleInfo = { VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO };
moduleInfo.codeSize = codeBuffer.size(); moduleInfo.codeSize = codeBuffer.size();
moduleInfo.pCode = codeBuffer.data(); moduleInfo.pCode = codeBuffer.data();
VkShaderModule shaderModule = VK_NULL_HANDLE;
if (!m_device->features().extGraphicsPipelineLibrary.graphicsPipelineLibrary) {
auto vk = m_device->vkd();
if (vk->vkCreateShaderModule(vk->device(), &moduleInfo, nullptr, &shaderModule))
throw DxvkError("DxvkShaderStageInfo: Failed to create shader module");
}
// Set up shader stage info with the data provided
auto& stageInfo = m_stageInfos[m_stageCount]; auto& stageInfo = m_stageInfos[m_stageCount];
stageInfo = { VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO }; stageInfo = { VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO, &moduleInfo };
if (!stageInfo.module)
stageInfo.pNext = &moduleInfo;
stageInfo.stage = stage; stageInfo.stage = stage;
stageInfo.module = shaderModule;
stageInfo.pName = "main"; stageInfo.pName = "main";
stageInfo.pSpecializationInfo = specInfo; stageInfo.pSpecializationInfo = specInfo;
@ -1208,12 +1191,7 @@ namespace dxvk {
DxvkShaderStageInfo::~DxvkShaderStageInfo() { DxvkShaderStageInfo::~DxvkShaderStageInfo() {
auto vk = m_device->vkd();
for (uint32_t i = 0; i < m_stageCount; i++) {
if (m_stageInfos[i].module)
vk->vkDestroyShaderModule(vk->device(), m_stageInfos[i].module, nullptr);
}
} }