From 9ee4add77e0d3b0c22273c5c2b4101fbb9444f10 Mon Sep 17 00:00:00 2001
From: Joshua Ashton <joshua@froggi.es>
Date: Mon, 25 May 2020 09:26:09 +0100
Subject: [PATCH] [dxso] Forbid FETCH4 for 3D and not Cube

SPIR-V spec contradicts itself as to what is allowed here, and SPIR-V val doesn't help by listing the wrong dimension.
---
 src/dxso/dxso_compiler.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/dxso/dxso_compiler.cpp b/src/dxso/dxso_compiler.cpp
index d98c6417c..b027d2c7b 100644
--- a/src/dxso/dxso_compiler.cpp
+++ b/src/dxso/dxso_compiler.cpp
@@ -2771,7 +2771,7 @@ void DxsoCompiler::emitControlFlowGenericLoop(
       }
 
       uint32_t fetch4 = 0;
-      if (m_programInfo.type() == DxsoProgramType::PixelShader && samplerType != SamplerTypeTextureCube) {
+      if (m_programInfo.type() == DxsoProgramType::PixelShader && samplerType != SamplerTypeTexture3D) {
         fetch4 = m_module.opBitFieldUExtract(
           m_module.defIntType(32, 0), m_ps.fetch4Spec,
           m_module.consti32(samplerIdx), m_module.consti32(1));