rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-01-31 14:52:11 +01:00
Code Issues Projects Releases Wiki Activity

[d3d8] Add an option to respect DISCARD only for dynamic write-only buffers

Browse Source
This commit is contained in:
WinterSnowfall 2024-07-13 20:17:09 +03:00 committed by Philip Rebohle
parent 4fad20d77c
commit a7b3b1e3a4
3 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/d3d8/d3d8_buffer.h
View File

@ -18,6 +18,7 @@ namespace dxvk {
: D3D8Resource<D3D9, D3D8> (pDevice, std::move(pBuffer))
, m_pool (Pool)
, m_usage (Usage) {
m_options = this->GetParent()->GetOptions();
}
HRESULT STDMETHODCALLTYPE Lock(
@ -25,6 +26,13 @@ namespace dxvk {
UINT SizeToLock,
BYTE** ppbData,
DWORD Flags) {
if (m_options->forceLegacyDiscard &&
(Flags & D3DLOCK_DISCARD) &&
!((m_usage & D3DUSAGE_DYNAMIC) &&
(m_usage & D3DUSAGE_WRITEONLY)))
Flags &= ~D3DLOCK_DISCARD;
return this->GetD3D9()->Lock(
OffsetToLock,
SizeToLock,
@ -41,8 +49,9 @@ namespace dxvk {
}
protected:
const D3DPOOL m_pool;
const DWORD m_usage;
const D3D8Options* m_options;
const D3DPOOL m_pool;
const DWORD m_usage;
};

4
src/d3d8/d3d8_device.h
View File

@ -358,6 +358,10 @@ namespace dxvk {
public: // Internal Methods //
const D3D8Options* GetOptions() const {
return &m_d3d8Options;
}
inline bool ShouldRecord() { return m_recorder != nullptr; }
inline bool ShouldBatch() { return m_batcher != nullptr; }

8
src/d3d8/d3d8_options.h
View File

@ -34,11 +34,19 @@ namespace dxvk {
/// and above. Most likely ATI/AMD drivers never supported P8 in the first place.
bool placeP8InScratch = false;
/// Rayman 3 relies on D3DLOCK_DISCARD being ignored for everything except D3DUSAGE_DYNAMIC +
/// D3DUSAGE_WRITEONLY buffers, however this approach incurs a performance penalty.
///
/// Some titles might abuse this early D3D8 quirk, however at some point in its history
/// it was brought in line with standard D3D9 behavior.
bool forceLegacyDiscard = false;
D3D8Options() {}
D3D8Options(const Config& config) {
auto forceVsDeclStr = config.getOption<std::string>("d3d8.forceVsDecl", "");
batching = config.getOption<bool> ("d3d8.batching", batching);
placeP8InScratch = config.getOption<bool> ("d3d8.placeP8InScratch", placeP8InScratch);
forceLegacyDiscard = config.getOption<bool> ("d3d8.forceLegacyDiscard", forceLegacyDiscard);
parseVsDecl(forceVsDeclStr);
}