rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-02-20 19:54:19 +01:00
Code Issues Projects Releases Wiki Activity

[dxvk] Clean up check whether buffer can be relocated

Browse Source
This commit is contained in:
Philip Rebohle 2024-09-29 12:39:35 +02:00 committed by Philip Rebohle
parent b164d6e2a7
commit abd888a0bb
3 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/dxvk/dxvk_buffer.cpp
View File

@ -47,6 +47,13 @@ namespace dxvk {
}
bool DxvkBuffer::canRelocate() const {
return !m_storage->flags().test(DxvkAllocationFlag::Imported)
&& !m_bufferInfo.mapPtr
&& !(m_info.usage & VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT)
&& !(m_info.flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT);
}
Rc<DxvkBufferView> DxvkBuffer::createView(
const DxvkBufferViewKey& info) {

11
src/dxvk/dxvk_buffer.h
View File

@ -342,12 +342,13 @@ namespace dxvk {
}
/**
* \brief Checks whether the buffer is imported
* \returns \c true if the buffer is imported
* \brief Checks whether the buffer can be relocated
*
* Buffers that require a stable GPU or CPU address cannot be
* moved, unless it's done explicitly done by the client API.
* \returns \c true if the backend can safely relocate the buffer
*/
bool isForeign() const {
return m_storage->flags().test(DxvkAllocationFlag::Imported);
}
bool canRelocate() const;
/**
* \brief Creates or retrieves a buffer view

16
src/dxvk/dxvk_context.cpp
View File

@ -6478,20 +6478,8 @@ namespace dxvk {
if (copySize != buffer->info().size || copySize > 0x40000)
return false;
// Don't discard host-visible buffers since that may interfere with the frontend
if (buffer->memFlags() & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT)
return false;
// Don't discard sparse buffers
if (buffer->info().flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)
return false;
// Don't discard imported buffers
if (buffer->isForeign())
return false;
// Don't discard buffers that need a stable device address
if (buffer->info().usage & VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT)
// Check if the buffer is safe to move at all
if (!buffer->canRelocate())
return false;
// Suspend the current render pass if transform feedback is active prior to