rooty/dxvk
1
0
Fork 0
mirror of https://github.com/doitsujin/dxvk.git synced 2025-01-31 14:52:11 +01:00
Code Issues Projects Releases Wiki Activity

[d3d9] Remove incorrect error returns SetDialogBoxMode

Browse Source 
The Microsoft docs for this are incorrect based on my tests of all the described edge-cases.
https://docs.microsoft.com/en-us/windows/win32/api/d3d9/nf-d3d9-idirect3ddevice9-setdialogboxmode
This commit is contained in:
Joshua Ashton 2020-01-04 21:09:58 +00:00
parent ae01bd8bd4
commit d53b3adaea
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/d3d9/d3d9_swapchain.cpp
View File

@ -402,18 +402,10 @@ namespace dxvk {
HRESULT D3D9SwapChainEx::SetDialogBoxMode(bool bEnableDialogs) { HRESULT D3D9SwapChainEx::SetDialogBoxMode(bool bEnableDialogs) {
if (bEnableDialogs) { // https://docs.microsoft.com/en-us/windows/win32/api/d3d9/nf-d3d9-idirect3ddevice9-setdialogboxmode
if (m_presentParams.BackBufferFormat != D3DFMT_X1R5G5B5 && // The MSDN documentation says this will error out under many weird conditions.
m_presentParams.BackBufferFormat != D3DFMT_R5G6B5 && // However it doesn't appear to error at all in any of my tests of these
m_presentParams.BackBufferFormat != D3DFMT_X8R8G8B8) // cases described in the documentation.
return D3DERR_INVALIDCALL;
if (m_presentParams.SwapEffect == D3DSWAPEFFECT_DISCARD)
return D3DERR_INVALIDCALL;
if (m_presentParams.Flags & D3DPRESENTFLAG_LOCKABLE_BACKBUFFER)
return D3DERR_INVALIDCALL;
}
m_dialogChanged = m_dialog != bEnableDialogs; m_dialogChanged = m_dialog != bEnableDialogs;
m_dialog = bEnableDialogs; m_dialog = bEnableDialogs;