From fa4f40a0e6a8ce7a9acd02a3a66e106ffa4ebf70 Mon Sep 17 00:00:00 2001 From: Philip Rebohle Date: Mon, 23 Aug 2021 17:30:05 +0200 Subject: [PATCH] [dxvk] Remove transform feedback self-dependency from render passes Fixes a whole bunch of validaton errors since this was technically invalid. --- src/dxvk/dxvk_renderpass.cpp | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/dxvk/dxvk_renderpass.cpp b/src/dxvk/dxvk_renderpass.cpp index 71d58461..0dae186e 100644 --- a/src/dxvk/dxvk_renderpass.cpp +++ b/src/dxvk/dxvk_renderpass.cpp @@ -140,7 +140,7 @@ namespace dxvk { if (m_format.depth.format == VK_FORMAT_UNDEFINED) subpass.pDepthStencilAttachment = nullptr; - std::array subpassDeps; + std::array subpassDeps; uint32_t subpassDepCount = 0; VkPipelineStageFlags renderStages = 0; @@ -187,17 +187,6 @@ namespace dxvk { 0, renderAccess }; } - if (ops.barrier.srcStages & ( - VK_PIPELINE_STAGE_TRANSFORM_FEEDBACK_BIT_EXT | - VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT | - VK_PIPELINE_STAGE_ALL_COMMANDS_BIT)) { - subpassDeps[subpassDepCount++] = { 0, 0, - VK_PIPELINE_STAGE_TRANSFORM_FEEDBACK_BIT_EXT, - VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, /* XXX */ - VK_ACCESS_TRANSFORM_FEEDBACK_COUNTER_WRITE_BIT_EXT, - VK_ACCESS_TRANSFORM_FEEDBACK_COUNTER_READ_BIT_EXT, 0 }; - } - if (ops.barrier.srcStages & ( VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT | VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT |