mirror of
https://github.com/doitsujin/dxvk.git
synced 2024-12-12 13:08:50 +01:00
5ea8648cd9
When a null ppvObject is passed into a QueryInterface on any IUnknown, a E_POINTER should be returned as the result (and it should not crash.) This matches native d3d11/d3d10/dxgi behaviour and the documentation found here https://docs.microsoft.com/en-us/windows/desktop/api/unknwn/nf-unknwn-iunknown-queryinterface(q_) for IUnknown.
312 lines
11 KiB
C++
312 lines
11 KiB
C++
#include "d3d11_device.h"
|
|
#include "d3d11_buffer.h"
|
|
#include "d3d11_resource.h"
|
|
#include "d3d11_texture.h"
|
|
#include "d3d11_view_uav.h"
|
|
|
|
namespace dxvk {
|
|
|
|
D3D11UnorderedAccessView::D3D11UnorderedAccessView(
|
|
D3D11Device* pDevice,
|
|
ID3D11Resource* pResource,
|
|
const D3D11_UNORDERED_ACCESS_VIEW_DESC* pDesc)
|
|
: m_device(pDevice), m_resource(pResource), m_desc(*pDesc) {
|
|
ResourceAddRefPrivate(m_resource);
|
|
|
|
D3D11_RESOURCE_DIMENSION resourceDim = D3D11_RESOURCE_DIMENSION_UNKNOWN;
|
|
pResource->GetType(&resourceDim);
|
|
|
|
if (resourceDim == D3D11_RESOURCE_DIMENSION_BUFFER) {
|
|
auto buffer = static_cast<D3D11Buffer*>(pResource);
|
|
|
|
DxvkBufferViewCreateInfo viewInfo;
|
|
|
|
if (pDesc->Buffer.Flags & D3D11_BUFFEREX_SRV_FLAG_RAW) {
|
|
viewInfo.format = VK_FORMAT_R32_UINT;
|
|
viewInfo.rangeOffset = sizeof(uint32_t) * pDesc->Buffer.FirstElement;
|
|
viewInfo.rangeLength = sizeof(uint32_t) * pDesc->Buffer.NumElements;
|
|
} else if (pDesc->Format == DXGI_FORMAT_UNKNOWN) {
|
|
viewInfo.format = VK_FORMAT_R32_UINT;
|
|
viewInfo.rangeOffset = buffer->Desc()->StructureByteStride * pDesc->Buffer.FirstElement;
|
|
viewInfo.rangeLength = buffer->Desc()->StructureByteStride * pDesc->Buffer.NumElements;
|
|
} else {
|
|
viewInfo.format = pDevice->LookupFormat(pDesc->Format, DXGI_VK_FORMAT_MODE_COLOR).Format;
|
|
|
|
const DxvkFormatInfo* formatInfo = imageFormatInfo(viewInfo.format);
|
|
viewInfo.rangeOffset = formatInfo->elementSize * pDesc->Buffer.FirstElement;
|
|
viewInfo.rangeLength = formatInfo->elementSize * pDesc->Buffer.NumElements;
|
|
}
|
|
|
|
if (pDesc->Buffer.Flags & (D3D11_BUFFER_UAV_FLAG_APPEND | D3D11_BUFFER_UAV_FLAG_COUNTER))
|
|
m_counterSlice = pDevice->AllocUavCounterSlice();
|
|
|
|
m_bufferView = pDevice->GetDXVKDevice()->createBufferView(
|
|
buffer->GetBuffer(), viewInfo);
|
|
} else {
|
|
const DXGI_VK_FORMAT_INFO formatInfo = pDevice->LookupFormat(
|
|
pDesc->Format, GetCommonTexture(pResource)->GetFormatMode());
|
|
|
|
DxvkImageViewCreateInfo viewInfo;
|
|
viewInfo.format = formatInfo.Format;
|
|
viewInfo.aspect = formatInfo.Aspect;
|
|
viewInfo.swizzle = formatInfo.Swizzle;
|
|
viewInfo.usage = VK_IMAGE_USAGE_STORAGE_BIT;
|
|
|
|
switch (pDesc->ViewDimension) {
|
|
case D3D11_UAV_DIMENSION_TEXTURE1D:
|
|
viewInfo.type = VK_IMAGE_VIEW_TYPE_1D;
|
|
viewInfo.minLevel = pDesc->Texture1D.MipSlice;
|
|
viewInfo.numLevels = 1;
|
|
viewInfo.minLayer = 0;
|
|
viewInfo.numLayers = 1;
|
|
break;
|
|
|
|
case D3D11_UAV_DIMENSION_TEXTURE1DARRAY:
|
|
viewInfo.type = VK_IMAGE_VIEW_TYPE_1D_ARRAY;
|
|
viewInfo.minLevel = pDesc->Texture1DArray.MipSlice;
|
|
viewInfo.numLevels = 1;
|
|
viewInfo.minLayer = pDesc->Texture1DArray.FirstArraySlice;
|
|
viewInfo.numLayers = pDesc->Texture1DArray.ArraySize;
|
|
break;
|
|
|
|
case D3D11_UAV_DIMENSION_TEXTURE2D:
|
|
viewInfo.type = VK_IMAGE_VIEW_TYPE_2D;
|
|
viewInfo.minLevel = pDesc->Texture2D.MipSlice;
|
|
viewInfo.numLevels = 1;
|
|
viewInfo.minLayer = 0;
|
|
viewInfo.numLayers = 1;
|
|
break;
|
|
|
|
case D3D11_UAV_DIMENSION_TEXTURE2DARRAY:
|
|
viewInfo.type = VK_IMAGE_VIEW_TYPE_2D_ARRAY;
|
|
viewInfo.minLevel = pDesc->Texture2DArray.MipSlice;
|
|
viewInfo.numLevels = 1;
|
|
viewInfo.minLayer = pDesc->Texture2DArray.FirstArraySlice;
|
|
viewInfo.numLayers = pDesc->Texture2DArray.ArraySize;
|
|
break;
|
|
|
|
case D3D11_UAV_DIMENSION_TEXTURE3D:
|
|
// FIXME we actually have to map this to a
|
|
// 2D array view in order to support W slices
|
|
viewInfo.type = VK_IMAGE_VIEW_TYPE_3D;
|
|
viewInfo.minLevel = pDesc->Texture3D.MipSlice;
|
|
viewInfo.numLevels = 1;
|
|
viewInfo.minLayer = 0;
|
|
viewInfo.numLayers = 1;
|
|
break;
|
|
|
|
default:
|
|
throw DxvkError("D3D11: Invalid view dimension for image UAV");
|
|
}
|
|
|
|
m_imageView = pDevice->GetDXVKDevice()->createImageView(
|
|
GetCommonTexture(pResource)->GetImage(), viewInfo);
|
|
}
|
|
}
|
|
|
|
|
|
D3D11UnorderedAccessView::~D3D11UnorderedAccessView() {
|
|
ResourceReleasePrivate(m_resource);
|
|
|
|
if (m_counterSlice.defined())
|
|
m_device->FreeUavCounterSlice(m_counterSlice);
|
|
}
|
|
|
|
|
|
HRESULT STDMETHODCALLTYPE D3D11UnorderedAccessView::QueryInterface(REFIID riid, void** ppvObject) {
|
|
if (ppvObject == nullptr)
|
|
return E_POINTER;
|
|
|
|
*ppvObject = nullptr;
|
|
|
|
if (riid == __uuidof(IUnknown)
|
|
|| riid == __uuidof(ID3D11DeviceChild)
|
|
|| riid == __uuidof(ID3D11View)
|
|
|| riid == __uuidof(ID3D11UnorderedAccessView)) {
|
|
*ppvObject = ref(this);
|
|
return S_OK;
|
|
}
|
|
|
|
Logger::warn("D3D11UnorderedAccessView::QueryInterface: Unknown interface query");
|
|
Logger::warn(str::format(riid));
|
|
return E_NOINTERFACE;
|
|
}
|
|
|
|
|
|
void STDMETHODCALLTYPE D3D11UnorderedAccessView::GetDevice(ID3D11Device** ppDevice) {
|
|
*ppDevice = m_device.ref();
|
|
}
|
|
|
|
|
|
void STDMETHODCALLTYPE D3D11UnorderedAccessView::GetResource(ID3D11Resource** ppResource) {
|
|
*ppResource = ref(m_resource);
|
|
}
|
|
|
|
|
|
void STDMETHODCALLTYPE D3D11UnorderedAccessView::GetDesc(D3D11_UNORDERED_ACCESS_VIEW_DESC* pDesc) {
|
|
*pDesc = m_desc;
|
|
}
|
|
|
|
|
|
HRESULT D3D11UnorderedAccessView::GetDescFromResource(
|
|
ID3D11Resource* pResource,
|
|
D3D11_UNORDERED_ACCESS_VIEW_DESC* pDesc) {
|
|
D3D11_RESOURCE_DIMENSION resourceDim = D3D11_RESOURCE_DIMENSION_UNKNOWN;
|
|
pResource->GetType(&resourceDim);
|
|
|
|
switch (resourceDim) {
|
|
case D3D11_RESOURCE_DIMENSION_BUFFER: {
|
|
D3D11_BUFFER_DESC bufferDesc;
|
|
static_cast<D3D11Buffer*>(pResource)->GetDesc(&bufferDesc);
|
|
|
|
if (bufferDesc.MiscFlags == D3D11_RESOURCE_MISC_BUFFER_STRUCTURED) {
|
|
pDesc->Format = DXGI_FORMAT_UNKNOWN;
|
|
pDesc->ViewDimension = D3D11_UAV_DIMENSION_BUFFER;
|
|
pDesc->Buffer.FirstElement = 0;
|
|
pDesc->Buffer.NumElements = bufferDesc.ByteWidth / bufferDesc.StructureByteStride;
|
|
return S_OK;
|
|
}
|
|
} return E_INVALIDARG;
|
|
|
|
case D3D11_RESOURCE_DIMENSION_TEXTURE1D: {
|
|
D3D11_TEXTURE1D_DESC resourceDesc;
|
|
static_cast<D3D11Texture1D*>(pResource)->GetDesc(&resourceDesc);
|
|
|
|
pDesc->Format = resourceDesc.Format;
|
|
|
|
if (resourceDesc.ArraySize == 1) {
|
|
pDesc->ViewDimension = D3D11_UAV_DIMENSION_TEXTURE1D;
|
|
pDesc->Texture1D.MipSlice = 0;
|
|
} else {
|
|
pDesc->ViewDimension = D3D11_UAV_DIMENSION_TEXTURE1DARRAY;
|
|
pDesc->Texture1DArray.MipSlice = 0;
|
|
pDesc->Texture1DArray.FirstArraySlice = 0;
|
|
pDesc->Texture1DArray.ArraySize = resourceDesc.ArraySize;
|
|
}
|
|
} return S_OK;
|
|
|
|
case D3D11_RESOURCE_DIMENSION_TEXTURE2D: {
|
|
D3D11_TEXTURE2D_DESC resourceDesc;
|
|
static_cast<D3D11Texture2D*>(pResource)->GetDesc(&resourceDesc);
|
|
|
|
pDesc->Format = resourceDesc.Format;
|
|
|
|
if (resourceDesc.ArraySize == 1) {
|
|
pDesc->ViewDimension = D3D11_UAV_DIMENSION_TEXTURE2D;
|
|
pDesc->Texture2D.MipSlice = 0;
|
|
} else {
|
|
pDesc->ViewDimension = D3D11_UAV_DIMENSION_TEXTURE2DARRAY;
|
|
pDesc->Texture2DArray.MipSlice = 0;
|
|
pDesc->Texture2DArray.FirstArraySlice = 0;
|
|
pDesc->Texture2DArray.ArraySize = resourceDesc.ArraySize;
|
|
}
|
|
} return S_OK;
|
|
|
|
case D3D11_RESOURCE_DIMENSION_TEXTURE3D: {
|
|
D3D11_TEXTURE3D_DESC resourceDesc;
|
|
static_cast<D3D11Texture3D*>(pResource)->GetDesc(&resourceDesc);
|
|
|
|
pDesc->Format = resourceDesc.Format;
|
|
pDesc->ViewDimension = D3D11_UAV_DIMENSION_TEXTURE3D;
|
|
pDesc->Texture3D.MipSlice = 0;
|
|
} return S_OK;
|
|
|
|
default:
|
|
Logger::err(str::format(
|
|
"D3D11: Unsupported dimension for unordered access view: ",
|
|
resourceDim));
|
|
return E_INVALIDARG;
|
|
}
|
|
}
|
|
|
|
|
|
HRESULT D3D11UnorderedAccessView::NormalizeDesc(
|
|
ID3D11Resource* pResource,
|
|
D3D11_UNORDERED_ACCESS_VIEW_DESC* pDesc) {
|
|
D3D11_RESOURCE_DIMENSION resourceDim = D3D11_RESOURCE_DIMENSION_UNKNOWN;
|
|
pResource->GetType(&resourceDim);
|
|
|
|
DXGI_FORMAT format = DXGI_FORMAT_UNKNOWN;
|
|
uint32_t numLayers = 0;
|
|
|
|
switch (resourceDim) {
|
|
case D3D11_RESOURCE_DIMENSION_BUFFER: {
|
|
if (pDesc->ViewDimension != D3D11_UAV_DIMENSION_BUFFER) {
|
|
Logger::err("D3D11: Incompatible view dimension for Buffer");
|
|
return E_INVALIDARG;
|
|
}
|
|
} break;
|
|
|
|
case D3D11_RESOURCE_DIMENSION_TEXTURE1D: {
|
|
D3D11_TEXTURE1D_DESC resourceDesc;
|
|
static_cast<D3D11Texture1D*>(pResource)->GetDesc(&resourceDesc);
|
|
|
|
if (pDesc->ViewDimension != D3D11_UAV_DIMENSION_TEXTURE1D
|
|
&& pDesc->ViewDimension != D3D11_UAV_DIMENSION_TEXTURE1DARRAY) {
|
|
Logger::err("D3D11: Incompatible view dimension for Texture1D");
|
|
return E_INVALIDARG;
|
|
}
|
|
|
|
format = resourceDesc.Format;
|
|
numLayers = resourceDesc.ArraySize;
|
|
} break;
|
|
|
|
case D3D11_RESOURCE_DIMENSION_TEXTURE2D: {
|
|
D3D11_TEXTURE2D_DESC resourceDesc;
|
|
static_cast<D3D11Texture2D*>(pResource)->GetDesc(&resourceDesc);
|
|
|
|
if (pDesc->ViewDimension != D3D11_UAV_DIMENSION_TEXTURE2D
|
|
&& pDesc->ViewDimension != D3D11_UAV_DIMENSION_TEXTURE2DARRAY) {
|
|
Logger::err("D3D11: Incompatible view dimension for Texture2D");
|
|
return E_INVALIDARG;
|
|
}
|
|
|
|
format = resourceDesc.Format;
|
|
numLayers = resourceDesc.ArraySize;
|
|
} break;
|
|
|
|
case D3D11_RESOURCE_DIMENSION_TEXTURE3D: {
|
|
D3D11_TEXTURE3D_DESC resourceDesc;
|
|
static_cast<D3D11Texture3D*>(pResource)->GetDesc(&resourceDesc);
|
|
|
|
if (pDesc->ViewDimension != D3D11_UAV_DIMENSION_TEXTURE3D) {
|
|
Logger::err("D3D11: Incompatible view dimension for Texture3D");
|
|
return E_INVALIDARG;
|
|
}
|
|
|
|
format = resourceDesc.Format;
|
|
numLayers = resourceDesc.Depth >> pDesc->Texture3D.MipSlice;
|
|
} break;
|
|
|
|
default:
|
|
return E_INVALIDARG;
|
|
}
|
|
|
|
if (pDesc->Format == DXGI_FORMAT_UNKNOWN)
|
|
pDesc->Format = format;
|
|
|
|
switch (pDesc->ViewDimension) {
|
|
case D3D11_UAV_DIMENSION_TEXTURE1DARRAY:
|
|
if (pDesc->Texture1DArray.ArraySize > numLayers - pDesc->Texture1DArray.FirstArraySlice)
|
|
pDesc->Texture1DArray.ArraySize = numLayers - pDesc->Texture1DArray.FirstArraySlice;
|
|
break;
|
|
|
|
case D3D11_UAV_DIMENSION_TEXTURE2DARRAY:
|
|
if (pDesc->Texture2DArray.ArraySize > numLayers - pDesc->Texture2DArray.FirstArraySlice)
|
|
pDesc->Texture2DArray.ArraySize = numLayers - pDesc->Texture2DArray.FirstArraySlice;
|
|
break;
|
|
|
|
case D3D11_UAV_DIMENSION_TEXTURE3D:
|
|
if (pDesc->Texture3D.WSize > numLayers - pDesc->Texture3D.FirstWSlice)
|
|
pDesc->Texture3D.WSize = numLayers - pDesc->Texture3D.FirstWSlice;
|
|
break;
|
|
|
|
default:
|
|
break;
|
|
}
|
|
|
|
return S_OK;
|
|
}
|
|
|
|
}
|