rooty/fab-manager
1
0
Fork 0
mirror of https://github.com/LaCasemate/fab-manager.git synced 2025-02-20 14:54:15 +01:00
Code Issues Releases Activity

(bug) when an empty data was retured by the SSO, unable to edit it

Browse Source
This commit is contained in:
Sylvain 2022-06-27 12:51:38 +02:00
parent 46b2ba1f54
commit 0510a5f3a3
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -15,6 +15,7 @@
- Fixed all react components code according to eslint rules
- Renamed proof-of-identity to supporting-documents in react components and in end-user strings
- Fix a bug: when email was mapped from SSO provided as empty string -> unable to merge account
- Fix a bug: when an empty data was retured by the SSO, unable to edit it
- Fix a bug: the birthdate was not marked as required, in the profile edition form
- Fix a bug: when the phone or the address were required, they were not marked as this, in the profile edition form
- Fix a bug: the birthday was not shown in user edition form

2
app/models/concerns/single_sign_on_concern.rb
View File

@ -70,7 +70,7 @@ module SingleSignOnConcern
profile[sso_mapping[8..-1].to_sym] = data unless data.nil?
end
end
return if data.nil? || mapped_from_sso&.include?(sso_mapping)
return if data.nil? || data.blank? || mapped_from_sso&.include?(sso_mapping)
self.mapped_from_sso = [mapped_from_sso, sso_mapping].compact.join(',')
end