[bug] in some cases, bogus admin notification on profile completed

CHANGELOG.md

@@ -47,6 +47,7 @@
 - Fix a bug: theme colors must be selected twice before the changes became effective
 - Fix a bug: datepicker does not work in profile completion screen
 - Fix a bug: unable to select a group in profile completion screen
+- Fix a bug: in some cases, bogus admin notification on profile completed 
 - Fix a security issue: updated loofah to fix [CVE-2019-15587](https://github.com/advisories/GHSA-c3gv-9cxf-6f57)
 - Fix a security issue: updated angular to 1.7.9 to fix [CVE-2019-10768](https://github.com/advisories/GHSA-89mq-4x47-5v83)
 - Fix a security issue: updated puma to 3.12.2 to fix [GHSA-7xx3-m584-x994](https://github.com/advisories/GHSA-7xx3-m584-x994)

app/assets/javascripts/controllers/home.js

@@ -39,6 +39,12 @@ Application.Controllers.controller('HomeController', ['$scope', '$stateParams',
           window.removeEventListener('keydown', handleF1);
         });
       }
+
+      $scope.$watch('currentUser', function (newValue, oldValue) {
+        if (!oldValue && newValue && newValue.role === 'admin') {
+          setupWelcomeTour();
+        }
+      });
     };
 
     /**

app/views/api/notifications/_notify_admin_profile_complete.json.jbuilder

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
+default_provider = AuthProvider.find_by(providable_type: DatabaseProvider.name).name
 json.title notification.notification_type
 json.description t('.account_imported_from_PROVIDER_UID_has_completed_its_information_html',
-                   PROVIDER: notification.attached_object.provider,
-                   UID: notification.attached_object.uid)
+                   PROVIDER: notification.attached_object.provider || default_provider,
+                   UID: notification.attached_object.uid || notification.attached_object.id)
 json.url notification_url(notification, format: :json)