[bug] deleting a coupon displays an error message

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fix a bug: invalid link to the user's manual
 - Fix a bug: unable to sync coupons on stripe
 - Fix a bug: ignored coupon when booking an event with card payment
+- Fix a bug: deleting a coupon displays an error message
 
 ## v5.0.4 2021 June 15
 

app/models/coupon.rb

@@ -6,7 +6,7 @@ class Coupon < ApplicationRecord
   has_many :payment_schedule
 
   after_create :create_gateway_coupon
-  after_commit :delete_gateway_coupon, on: [:destroy]
+  before_destroy :delete_gateway_coupon
 
   validates :name, presence: true
   validates :code, presence: true

config/routes.rb

@@ -78,9 +78,10 @@ Rails.application.routes.draw do
     resources :prices, only: %i[index update] do
       post 'compute', on: :collection
     end
-    resources :coupons
-    post 'coupons/validate' => 'coupons#validate'
-    post 'coupons/send' => 'coupons#send_to'
+    resources :coupons do
+      post 'validate', action: 'validate', on: :collection
+      post 'send', action: 'send_to', on: :collection
+    end
 
     resources :trainings_pricings, only: %i[index update]