From 2b805161775bce28fd55cdcf77d65d18912e9edf Mon Sep 17 00:00:00 2001 From: Sylvain Date: Wed, 5 Oct 2022 13:11:17 +0200 Subject: [PATCH] (bug) unable to generate statistics This bug is due to the refactoring of the statistics builder service, in 2022 august. The default_options were not defined so the nightly worker has no luck to run. The statistics may not have been built since then, so a rebuild is required --- CHANGELOG.md | 2 ++ app/services/statistics/builder_service.rb | 10 ++++++++++ test/services/statistic_service_test.rb | 4 ++++ 3 files changed, 16 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a570eb140..00250404c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ # Changelog Fab-manager - Ability to dismiss a user to a lower privileged role +- Fix a bug: unable to generate statistics +- [TODO DEPLOY] `rails fablab:maintenance:regenerate_statistics[2022,08]` ## v5.4.20 2022 September 27 diff --git a/app/services/statistics/builder_service.rb b/app/services/statistics/builder_service.rb index 78e3a829a..53d7a49a5 100644 --- a/app/services/statistics/builder_service.rb +++ b/app/services/statistics/builder_service.rb @@ -12,5 +12,15 @@ class Statistics::BuilderService Statistics::Builders::MembersBuilderService.build(options) Statistics::Builders::ProjectsBuilderService.build(options) end + + private + + def default_options + yesterday = 1.day.ago + { + start_date: yesterday.beginning_of_day, + end_date: yesterday.end_of_day + } + end end end diff --git a/test/services/statistic_service_test.rb b/test/services/statistic_service_test.rb index db10ba4b8..ef1556fa1 100644 --- a/test/services/statistic_service_test.rb +++ b/test/services/statistic_service_test.rb @@ -9,6 +9,10 @@ class StatisticServiceTest < ActionDispatch::IntegrationTest login_as(@admin, scope: :user) end + test 'build default stats' do + ::Statistics::BuilderService.generate_statistic + end + test 'build stats' do # Create a reservation to generate an invoice machine = Machine.find(1)