Removed MESSAGEFORMAT_LOCALE as it is now handled by make-plural

CHANGELOG.md

@@ -3,6 +3,7 @@
 - Docker build will no longer embed development dependencies
 - Updated instructions to setup a development environment
 - Updated translations
+- Removed `MESSAGEFORMAT_LOCALE` as it is now handled by make-plural
 - Updated angular-translate
 - Updated eslint
 - Updated compass-rails & compass-core

app/views/application/index.html.erb

@@ -139,7 +139,6 @@
 
 <!-- i18n of external libraries -->
 <script type="text/javascript" src="<%= asset_path "angular-i18n/angular-locale_#{Rails.application.secrets.angular_locale}.js" %>"></script>
-<script type="text/javascript" src="<%= asset_path "messageformat/locale/#{Rails.application.secrets.messageformat_locale}.js" %>"></script>
 <% if Rails.env.staging? && Rails.application.secrets.enable_in_context_translation %>
   <script type="text/javascript">MessageFormat.locale.ach=function(n){return n===0||n===1?"one":"other"};</script>
 <% end %>

config/application.yml.default

@@ -69,7 +69,6 @@ APP_LOCALE: 'fr'
 MOMENT_LOCALE: 'fr'
 SUMMERNOTE_LOCALE: 'fr-FR'
 ANGULAR_LOCALE: 'fr-fr'
-MESSAGEFORMAT_LOCALE: 'fr'
 FULLCALENDAR_LOCALE: 'fr'
 
 ELASTICSEARCH_LANGUAGE_ANALYZER: 'french'

config/initializers/assets.rb

@@ -35,6 +35,5 @@ Rails.application.config.assets.precompile += %w[
   angular-i18n/angular-locale_*.js
   moment/locale/*.js
   summernote/lang/*.js
-  messageformat/locale/*.js
   fullcalendar/dist/lang/*.js
 ]

config/secrets.yml

@@ -39,7 +39,6 @@ development:
   moment_locale: <%= ENV["MOMENT_LOCALE"] %>
   summernote_locale: <%= ENV["SUMMERNOTE_LOCALE"] %>
   angular_locale: <%= ENV["ANGULAR_LOCALE"] %>
-  messageformat_locale: <%= ENV["MESSAGEFORMAT_LOCALE"] %>
   fullcalendar_locale: <%= ENV["FULLCALENDAR_LOCALE"] %>
   elasticsearch_language_analyzer: <%= ENV["ELASTICSEARCH_LANGUAGE_ANALYZER"] %>
   openlab_app_secret: <%= ENV["OPENLAB_APP_SECRET"] %>
@@ -88,7 +87,6 @@ test:
   moment_locale: en
   summernote_locale: en-US
   angular_locale: en-us
-  messageformat_locale: en
   fullcalendar_locale: en
   elasticsearch_language_analyzer: french
   openlab_app_secret:
@@ -145,7 +143,6 @@ staging:
   moment_locale: <%= ENV["MOMENT_LOCALE"] %>
   summernote_locale: <%= ENV["SUMMERNOTE_LOCALE"] %>
   angular_locale: <%= ENV["ANGULAR_LOCALE"] %>
-  messageformat_locale: <%= ENV["MESSAGEFORMAT_LOCALE"] %>
   fullcalendar_locale: <%= ENV["FULLCALENDAR_LOCALE"] %>
   elasticsearch_language_analyzer: <%= ENV["ELASTICSEARCH_LANGUAGE_ANALYZER"] %>
   openlab_app_secret: <%= ENV["OPENLAB_APP_SECRET"] %>
@@ -206,7 +203,6 @@ production:
   moment_locale: <%= ENV["MOMENT_LOCALE"] %>
   summernote_locale: <%= ENV["SUMMERNOTE_LOCALE"] %>
   angular_locale: <%= ENV["ANGULAR_LOCALE"] %>
-  messageformat_locale: <%= ENV["MESSAGEFORMAT_LOCALE"] %>
   fullcalendar_locale: <%= ENV["FULLCALENDAR_LOCALE"] %>
   elasticsearch_language_analyzer: <%= ENV["ELASTICSEARCH_LANGUAGE_ANALYZER"] %>
   openlab_app_secret: <%= ENV["OPENLAB_APP_SECRET"] %>

doc/environment.md

@@ -312,13 +312,6 @@ Please, be aware that **the configured locale will imply the CURRENCY displayed
 _Eg.: configuring **fr-fr** will set the currency symbol to **€** but **fr-ca** will set **$** as currency symbol, so setting the `ANGULAR_LOCALE` to simple **fr** (without country indication) will probably not do what you expect._
 
 See [code.angularjs.org/i18n/angular-locale_*.js](https://code.angularjs.org/1.6.10/i18n/) for a list of available locales. Default is **en**.
-<a name="MESSAGEFORMAT_LOCALE"></a>
-
-    MESSAGEFORMAT_LOCALE
-
-Configure the messageformat.js library, used by angular-translate.
-
-See [github.com/messageformat/messageformat/locale/*.js](https://github.com/messageformat/messageformat/tree/v0.1.8/locale) for a list of available locales.
 <a name="FULLCALENDAR_LOCALE"></a>
 
     FULLCALENDAR_LOCALE

env.example

@@ -69,7 +69,6 @@ APP_LOCALE=fr
 MOMENT_LOCALE=fr
 SUMMERNOTE_LOCALE=fr-FR
 ANGULAR_LOCALE=fr-fr
-MESSAGEFORMAT_LOCALE=fr
 FULLCALENDAR_LOCALE=fr
 
 ELASTICSEARCH_LANGUAGE_ANALYZER=french

setup/env.example

@@ -51,7 +51,6 @@ APP_LOCALE=fr
 MOMENT_LOCALE=fr
 SUMMERNOTE_LOCALE=fr-FR
 ANGULAR_LOCALE=fr-fr
-MESSAGEFORMAT_LOCALE=fr
 FULLCALENDAR_LOCALE=fr
 
 ELASTICSEARCH_LANGUAGE_ANALYZER=french

setup/setup.sh

@@ -224,7 +224,7 @@ configure_env_file()
    PHONE_REQUIRED BOOK_SLOT_AT_SAME_TIME USER_CONFIRMATION_NEEDED_TO_SIGN_IN EVENTS_IN_CALENDAR SLOT_DURATION DEFAULT_MAIL_FROM DELIVERY_METHOD DEFAULT_HOST DEFAULT_PROTOCOL SMTP_ADDRESS SMTP_PORT SMTP_USER_NAME SMTP_PASSWORD SMTP_AUTHENTICATION \
    SMTP_ENABLE_STARTTLS_AUTO SMTP_OPENSSL_VERIFY_MODE SMTP_TLS GA_ID RECAPTCHA_SITE_KEY RECAPTCHA_SECRET_KEY DISQUS_SHORTNAME TWITTER_NAME \
    FACEBOOK_APP_ID LOG_LEVEL ALLOWED_EXTENSIONS ALLOWED_MIME_TYPES MAX_IMAGE_SIZE MAX_CAO_SIZE MAX_IMPORT_SIZE DISK_SPACE_MB_ALERT FEATURE_TOUR_DISPLAY \
-   SUPERADMIN_EMAIL APP_LOCALE RAILS_LOCALE MOMENT_LOCALE SUMMERNOTE_LOCALE ANGULAR_LOCALE MESSAGEFORMAT_LOCALE FULLCALENDAR_LOCALE ELASTICSEARCH_LANGUAGE_ANALYZER TIME_ZONE \
+   SUPERADMIN_EMAIL APP_LOCALE RAILS_LOCALE MOMENT_LOCALE SUMMERNOTE_LOCALE ANGULAR_LOCALE FULLCALENDAR_LOCALE ELASTICSEARCH_LANGUAGE_ANALYZER TIME_ZONE \
    WEEK_STARTING_DAY D3_DATE_FORMAT UIB_DATE_FORMAT EXCEL_DATE_FORMAT OPENLAB_APP_ID OPENLAB_APP_SECRET OPENLAB_DEFAULT)
   for variable in "${variables[@]}"; do
     local var_doc current