[bug] a message tells that creating a new plan fails, but it worked

CHANGELOG.md

@@ -1,5 +1,7 @@
 # Changelog Fab-manager
 
+- Fix a bug: a message tells that creating a new plan fails, but it worked
+
 ## v5.0.3 2021 June 14
 
 - Updated user's manual for v5

app/controllers/api/plans_controller.rb

@@ -26,11 +26,11 @@ class API::PlansController < API::ApiController
     type = plan_params[:type]
     partner = params[:plan][:partner_id].empty? ? nil : User.find(params[:plan][:partner_id])
 
-    res = PlansService.create(type, partner, plan_params)
-    if res.errors
-      render json: res.errors, status: :unprocessable_entity
+    plan = PlansService.create(type, partner, plan_params)
+    if plan.errors.keys.count.positive?
+      render json: plan.errors, status: :unprocessable_entity
     else
-      render json: res, status: :created
+      render json: plan, status: :created
     end
   end
 

app/services/plans_service.rb

@@ -14,11 +14,8 @@ class PlansService
         plan = type.constantize.new(params)
         if plan.save
           partner&.add_role :partner, plan
-          plan
-        else
-          puts plan.errors
-          { errors: plan.errors }
         end
+        plan
       end
     rescue PaymentGatewayError => e
       { errors: e.message }