Fix a bug: admin could not create new SupportingDocumentType (problem was on js side)

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## next release
 
 - Fix a bug: fix ReservationReminderWorker, was sending reservation reminder to users with a event reservation not validated by admin + adds tests for all scenarios
+- Fix a bug: admin could not create new SupportingDocumentType (problem was on js side)
 
 ## v6.1.2 2023 October 2
 

app/frontend/src/javascript/components/supporting-documents/supporting-documents-type-form.tsx

@@ -57,13 +57,20 @@ export const SupportingDocumentsTypeForm: React.FC<SupportingDocumentsTypeFormPr
     onChange('name', value);
   };
 
+  /**
+   * to know if select input for groups is display or not
+   */
+  const displayGroupsSelect = (): boolean => {
+    return (supportingDocumentType == null || supportingDocumentType?.document_type === 'User') && (groups.length > 0);
+  };
+
   return (
     <div className="supporting-documents-type-form">
       <div className="info-area">
         {t('app.admin.settings.account.supporting_documents_type_form.type_form_info')}
       </div>
       <form name="supportingDocumentTypeForm">
-        {supportingDocumentType?.document_type === 'User' &&
+        {displayGroupsSelect() &&
           <div className="field">
             <Select defaultValue={groupsValues()}
               placeholder={t('app.admin.settings.account.supporting_documents_type_form.select_group')}

app/frontend/src/javascript/components/supporting-documents/supporting-documents-types-list.tsx

@@ -49,7 +49,9 @@ const SupportingDocumentsTypesList: React.FC<SupportingDocumentsTypesListProps>
   // get groups
   useEffect(() => {
     GroupAPI.index({ disabled: false }).then(data => {
-      setGroups(data);
+      if (documentType === 'User') {
+        setGroups(data);
+      }
       SupportingDocumentTypeAPI.index({ document_type: documentType }).then(pData => {
         setSupportingDocumentsTypes(pData);
       });