rooty/fab-manager
1
0
Fork 0
mirror of https://github.com/LaCasemate/fab-manager.git synced 2025-02-26 20:54:21 +01:00
Code Issues Releases Activity

(test) training default settings

Browse Source
This commit is contained in:
Sylvain 2023-01-31 09:42:45 +01:00 committed by Sylvain
parent 2b42858229
commit 6fa12d3996
6 changed files with 34 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/services/trainings/authorization_service.rb
View File

@ -46,8 +46,8 @@ class Trainings::AuthorizationService
# @param training [Training]
# @return [Boolean]
def override_settings?(training)
training.authorization.to_s != Setting.find_by(name: 'trainings_authorization_validity').value.to_s ||
training.authorization_period.to_s != Setting.find_by(name: 'trainings_authorization_validity_duration').value.to_s
training.authorization.to_s != Setting.find_by(name: 'trainings_authorization_validity')&.value.to_s ||
training.authorization_period.to_s != Setting.find_by(name: 'trainings_authorization_validity_duration')&.value.to_s
end
end
end

6
app/services/trainings/auto_cancel_service.rb
View File

@ -62,9 +62,9 @@ class Trainings::AutoCancelService
# @param training [Training]
# @return [Boolean]
def override_settings?(training)
training.auto_cancel.to_s != Setting.find_by(name: 'trainings_auto_cancel').value.to_s ||
training.auto_cancel_threshold.to_s != Setting.find_by(name: 'trainings_auto_cancel_threshold').value.to_s ||
training.auto_cancel_deadline.to_s != Setting.find_by(name: 'trainings_auto_cancel_deadline').value.to_s
training.auto_cancel.to_s != Setting.find_by(name: 'trainings_auto_cancel')&.value.to_s ||
training.auto_cancel_threshold.to_s != Setting.find_by(name: 'trainings_auto_cancel_threshold')&.value.to_s ||
training.auto_cancel_deadline.to_s != Setting.find_by(name: 'trainings_auto_cancel_deadline')&.value.to_s
end
private

4
app/services/trainings/invalidation_service.rb
View File

@ -51,8 +51,8 @@ class Trainings::InvalidationService
# @param training [Training]
# @return [Boolean]
def override_settings?(training)
training.invalidation.to_s != Setting.find_by(name: 'trainings_invalidation_rule').value.to_s ||
training.invalidation_period.to_s != Setting.find_by(name: 'trainings_invalidation_rule_period').value.to_s
training.invalidation.to_s != Setting.find_by(name: 'trainings_invalidation_rule')&.value.to_s ||
training.invalidation_period.to_s != Setting.find_by(name: 'trainings_invalidation_rule_period')&.value.to_s
end
end
end

9
test/services/trainings/authorization_service_test.rb
View File

@ -36,4 +36,13 @@ class Trainings::AuthorizationServiceTest < ActiveSupport::TestCase
)
assert_not_nil notification, 'user notification was not created'
end
test 'training with default general parameters' do
assert_not Trainings::AuthorizationService.override_settings?(@training)
end
test 'training with specific parameters' do
@training.update(authorization: true, authorization_period: 3)
assert Trainings::AuthorizationService.override_settings?(@training)
end
end

9
test/services/trainings/auto_cancel_service_test.rb
View File

@ -160,4 +160,13 @@ class Trainings::AutoCancelServiceTest < ActiveSupport::TestCase
assert_equal transaction.transaction_type, 'credit'
assert_equal transaction.amount, r.invoice_items.first.amount
end
test 'training with default general parameters' do
assert_not Trainings::AutoCancelService.override_settings?(@training)
end
test 'training with specific parameters' do
@training.update(auto_cancel: true, auto_cancel_threshold: 3, auto_cancel_deadline: 24)
assert Trainings::AutoCancelService.override_settings?(@training)
end
end

9
test/services/trainings/invalidation_service_test.rb
View File

@ -75,4 +75,13 @@ class Trainings::InvalidationServiceTest < ActiveSupport::TestCase
)
assert_nil notification
end
test 'training with default general parameters' do
assert_not Trainings::InvalidationService.override_settings?(@training)
end
test 'training with specific parameters' do
@training.update(invalidation: true, invalidation_period: 3)
assert Trainings::InvalidationService.override_settings?(@training)
end
end