removed dead code + improved test suite

app/controllers/api/abuses_controller.rb

@@ -1,10 +1,6 @@
 class API::AbusesController < API::ApiController
   before_action :authenticate_user!, except: :create
 
-  def index
-    @groups = Group.all
-  end
-
   def create
     @abuse = Abuse.new(abuse_params)
     if @abuse.save

test/fixtures/assets.yml

@@ -62,65 +62,11 @@ asset_7:
   created_at: 2016-04-05 08:35:18.585573000 Z
   updated_at: 2016-04-05 08:35:18.585573000 Z
 
-asset_4:
-  id: 4
+asset_8:
+  id: 8
   viewable_id: 1
-  viewable_type: Event
-  attachment: event_image.jpg
-  type: EventImage
-  created_at: 2016-04-04 15:44:02.242194000 Z
-  updated_at: 2016-04-04 15:44:02.242194000 Z
-
-asset_5:
-  id: 5
-  viewable_id: 2
-  viewable_type: Event
-  attachment: event_image.jpg
-  type: EventImage
-  created_at: 2016-04-04 15:44:03.164384000 Z
-  updated_at: 2016-04-04 15:44:03.164384000 Z
-
-asset_6:
-  id: 6
-  viewable_id: 3
-  viewable_type: Event
-  attachment: event_image.jpg
-  type: EventImage
-  created_at: 2016-04-04 15:44:04.031482000 Z
-  updated_at: 2016-04-04 15:44:04.031482000 Z
-
-asset_3:
-  id: 3
-  viewable_id: 1
-  viewable_type: Project
-  attachment: project_image.jpg
-  type: ProjectImage
-  created_at: 2016-04-04 15:39:08.230159000 Z
-  updated_at: 2016-04-04 15:39:08.230159000 Z
-
-asset_1:
-  id: 1
-  viewable_id: 2
   viewable_type: Profile
   attachment: user_avatar.jpg
   type: UserAvatar
-  created_at: 2016-04-04 15:06:22.151882000 Z
-  updated_at: 2016-04-04 15:06:22.151882000 Z
-
-asset_2:
-  id: 2
-  viewable_id: 5
-  viewable_type: Profile
-  attachment: user_avatar.jpg
-  type: UserAvatar
-  created_at: 2016-04-04 15:31:14.607327000 Z
-  updated_at: 2016-04-04 15:31:14.607327000 Z
-
-asset_7:
-  id: 7
-  viewable_id: 3
-  viewable_type: Profile
-  attachment: user_avatar.jpg
-  type: UserAvatar
-  created_at: 2016-04-05 08:35:18.585573000 Z
-  updated_at: 2016-04-05 08:35:18.585573000 Z
+  created_at: 2018-12-27 14:48:52.141382000 Z
+  updated_at: 2018-12-27 14:48:52.141382000 Z

test/fixtures/users.yml

@@ -187,7 +187,7 @@ user_1:
   created_at: 2001-01-01 14:11:33.852719000 Z
   updated_at: 2016-04-05 08:36:08.362215000 Z
   is_allow_contact: true
-  group_id: 1
+  group_id: 3
   stp_customer_id: cus_8CyNk3UTi8lvCc
   slug: admin
   is_active: true

test/fixtures/users_roles.yml

@@ -27,30 +27,3 @@ users_role_6:
   user_id: 6
   role_id: 4
 
-users_role_0:
-  user_id: 1
-  role_id: 1
-
-users_role_1:
-  user_id: 2
-  role_id: 2
-
-users_role_2:
-  user_id: 3
-  role_id: 2
-
-users_role_3:
-  user_id: 4
-  role_id: 2
-
-users_role_4:
-  user_id: 5
-  role_id: 2
-
-users_role_5:
-  user_id: 6
-  role_id: 3
-
-users_role_6:
-  user_id: 6
-  role_id: 4

test/integration/admins_test.rb

@@ -15,23 +15,22 @@ class AdminsTest < ActionDispatch::IntegrationTest
   end
 
   test 'create an admin' do
-
     post '/api/admins',
          {
-             admin: {
-                 username: 'glepower',
-                 email: 'gerard.lepower@admins.net',
-                 profile_attributes: {
-                     first_name: 'Gérard',
-                     last_name: 'Lepower',
-                     gender: true,
-                     birthday: '1999-09-19',
-                     phone: '0547124852',
-                     address_attributes: {
-                         address: '6 Avenue Henri de Bournazel, 19000 Tulle'
-                     }
-                 }
+           admin: {
+             username: 'glepower',
+             email: 'gerard.lepower@admins.net',
+             profile_attributes: {
+               first_name: 'Gérard',
+               last_name: 'Lepower',
+               gender: true,
+               birthday: '1999-09-19',
+               phone: '0547124852',
+               address_attributes: {
+                 address: '6 Avenue Henri de Bournazel, 19000 Tulle'
+               }
              }
+           }
          }.to_json,
          default_headers
 
@@ -47,4 +46,21 @@ class AdminsTest < ActionDispatch::IntegrationTest
     # Check he's got the admin role
     assert user.has_role?(:admin), 'admin does not have the admin role'
   end
-end
+
+  test 'list all admins' do
+    get '/api/admins'
+
+
+    # Check response format & status
+    assert_equal 200, response.status, response.body
+    assert_equal Mime::JSON, response.content_type
+
+    # Check the list items are ok
+    admins = json_response(response.body)
+    assert_equal 1, admins.count, 'not all admins retrieved'
+    assert_equal @admin.id, admins[:admins][0][:id], 'admin id matches'
+    assert_equal @admin.profile.user_avatar.id,
+                 admins[:admins][0][:profile_attributes][:user_avatar][:id],
+                 'admin avatar does not match'
+  end
+end