From a50bb63b6414a74906f5d61521ebd37b61c72e0b Mon Sep 17 00:00:00 2001
From: Sylvain <bond.never.die@gmail.com>
Date: Wed, 27 Mar 2019 17:37:36 +0100
Subject: [PATCH] prevent double validation while closing period

---
 .../controllers/admin/invoices.js.erb         | 33 ++++++++++++-------
 .../admin/invoices/closePeriodModal.html.erb  |  4 +--
 2 files changed, 23 insertions(+), 14 deletions(-)

diff --git a/app/assets/javascripts/controllers/admin/invoices.js.erb b/app/assets/javascripts/controllers/admin/invoices.js.erb
index a211cf23c..cd0bd622f 100644
--- a/app/assets/javascripts/controllers/admin/invoices.js.erb
+++ b/app/assets/javascripts/controllers/admin/invoices.js.erb
@@ -699,6 +699,9 @@ Application.Controllers.controller('ClosePeriodModalController', ['$scope', '$ui
     // existing closed periods, provided by the API
     $scope.accountingPeriods = periods;
 
+    // closing a period may take a long time so we need to prevent the user from double-clicking the close button while processing
+    $scope.pendingCreation = false;
+
     // AngularUI-Bootstrap datepickers parameters to define the period to close
     $scope.datePicker = {
       format: Fablab.uibDateFormat,
@@ -740,22 +743,28 @@ Application.Controllers.controller('ClosePeriodModalController', ['$scope', '$ui
           }
         },
         function () { // creation confirmed
-          AccountingPeriod.save({
+          $scope.pendingCreation = true;
+          AccountingPeriod.save(
+            {
               accounting_period: {
                 start_at: moment.utc($scope.period.start_at).toDate(),
                 end_at: moment.utc($scope.period.end_at).endOf('day').toDate()
               }
-            }, function (resp) {
-            growl.success(_t(
-              'invoices.period_START_END_closed_success',
-              { START: moment.utc(resp.start_at).format('LL'), END: moment.utc(resp.end_at).format('LL') }
-            ));
-            $uibModalInstance.close(resp);
-          }
-          , function(error) {
-            growl.error(_t('invoices.failed_to_close_period'));
-            $scope.errors = error.data;
-          });
+            },
+            function (resp) {
+              $scope.pendingCreation = false;
+              growl.success(_t(
+                'invoices.period_START_END_closed_success',
+                { START: moment.utc(resp.start_at).format('LL'), END: moment.utc(resp.end_at).format('LL') }
+              ));
+              $uibModalInstance.close(resp);
+            },
+            function(error) {
+              $scope.pendingCreation = false;
+              growl.error(_t('invoices.failed_to_close_period'));
+              $scope.errors = error.data;
+            }
+          );
         }
       );
 
diff --git a/app/assets/templates/admin/invoices/closePeriodModal.html.erb b/app/assets/templates/admin/invoices/closePeriodModal.html.erb
index bb0f2f857..e75ade394 100644
--- a/app/assets/templates/admin/invoices/closePeriodModal.html.erb
+++ b/app/assets/templates/admin/invoices/closePeriodModal.html.erb
@@ -74,6 +74,6 @@
   </div>
 </div>
 <div class="modal-footer">
-  <button class="btn btn-warning" ng-click="ok()" ng-disabled="closePeriodForm.$invalid" translate>{{ 'confirm' }}</button>
-  <button class="btn btn-default" ng-click="cancel()" translate>{{ 'cancel' }}</button>
+  <button class="btn btn-warning" ng-click="ok()" ng-disabled="closePeriodForm.$invalid || pendingCreation" translate>{{ 'confirm' }}</button>
+  <button class="btn btn-default" ng-click="cancel()" ng-disabled="pendingCreation" translate>{{ 'cancel' }}</button>
 </div>