WIP: fix invoices without invoiced_id

TODO: fix datetime parsing

app/models/reservation.rb

@@ -23,7 +23,7 @@ class Reservation < ApplicationRecord
   validates_presence_of :reservable_id, :reservable_type
   validate :machine_not_already_reserved, if: -> { reservable.is_a?(Machine) }
   validate :training_not_fully_reserved, if: -> { reservable.is_a?(Training) }
-  validates_with ReservationSlotSubscriptionValidator
+  # validates_with ReservationSlotSubscriptionValidator
 
   attr_accessor :plan_id, :subscription
 

app/validators/reservation_slot_subscription_validator.rb

@@ -9,7 +9,7 @@ class ReservationSlotSubscriptionValidator < ActiveModel::Validator
         else
           # TODO, this validation requires to check if the operator is privileged.
           # Meanwhile we can't check this, we disable the validation
-          # record.errors[:slots] << 'slot is restrict for subscriptions'
+          record.errors[:slots] << 'slot is restrict for subscriptions'
         end
       end
     end

db/migrate/20210521073742_fix_invoices_without_invoiced_id.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'integrity/archive_helper'
-
 # This migration will ensure data integrity for invoices.
 # A bug introduced with v4.7.0 has made invoices without invoiced_id for Reservations.
 # This issue is concerning slots restricted to subscribers, when the restriction was manually overridden by an admin.
@@ -10,11 +8,16 @@ class FixInvoicesWithoutInvoicedId < ActiveRecord::Migration[5.2]
     return unless Invoice.where(invoiced_id: nil).count.positive?
 
     # check the footprints and save the archives
-    Integrity::ArchiveHelper.check_footprints
-    periods = Integrity::ArchiveHelper.backup_and_remove_periods
+    check_footprints
+    periods = backup_and_remove_periods
 
     # fix invoices data
     Invoice.where(invoiced_id: nil).each do |invoice|
+      if invoice.total.zero?
+        puts "Invoice #{invoice.id} has total = 0, destroying..."
+        invoice.destroy
+        next
+      end
       if invoice.invoiced_type != 'Reservation'
         STDERR.puts "WARNING: Invoice #{invoice.id} is not about a reservation, ignoring..."
         next
@@ -27,7 +30,7 @@ class FixInvoicesWithoutInvoicedId < ActiveRecord::Migration[5.2]
           STDERR.puts "WARNING: invoice #{invoice.id} may be linked to the Event #{reservable.id}. This is unsupported, ignoring..."
           next
         end
-        ::Reservation.create!(
+        reservation = ::Reservation.create!(
           reservable_id: reservable.id,
           reservable_type: reservable.class.name,
           slots_attributes: slots_attributes(invoice, reservable),
@@ -45,13 +48,70 @@ class FixInvoicesWithoutInvoicedId < ActiveRecord::Migration[5.2]
     Invoice.order(:id).all.each(&:chain_record)
 
     # re-create all archives from the memory dump
-    Integrity::ArchiveHelper.restore_periods(periods)
+    restore_periods(periods)
   end
 
   def down; end
 
   private
 
+  def check_footprints
+    if AccountingPeriod.count.positive?
+      last_period = AccountingPeriod.order(start_at: :desc).first
+      puts "Checking invoices footprints from #{last_period.end_at}. This may take a while..."
+      Invoice.where('created_at > ?', last_period.end_at).order(:id).each do |i|
+        raise "Invalid footprint for invoice #{i.id}" unless i.check_footprint
+      end
+    else
+      puts 'Checking all invoices footprints. This may take a while...'
+      Invoice.order(:id).all.each do |i|
+        raise "Invalid footprint for invoice #{i.id}" unless i.check_footprint
+      end
+    end
+  end
+
+  # will return an array of hash containing the removed periods data
+  def backup_and_remove_periods
+    return [] unless AccountingPeriod.where("created_at > '2019-08-01' AND created_at < '2020-05-12'").count.positive?
+
+    puts 'Removing erroneous accounting archives...'
+    # 1. remove protection for AccountingPeriods
+    execute("DROP RULE IF EXISTS accounting_periods_del_protect ON #{AccountingPeriod.arel_table.name};")
+    # 2. backup AccountingPeriods in memory
+    periods = []
+    AccountingPeriod.where("created_at > '2019-08-01'").each do |p|
+      periods.push(
+        start_at: p.start_at,
+        end_at: p.end_at,
+        closed_at: p.closed_at,
+        closed_by: p.closed_by
+      )
+    end
+    # 3. Delete periods from database
+    AccountingPeriod.where("created_at > '2019-08-01'").each do |ap|
+      execute("DELETE FROM accounting_periods WHERE ID=#{ap.id};")
+    end
+    periods
+  end
+
+  def restore_periods(periods)
+    return unless periods.size.positive?
+
+    # 1. recreate AccountingPeriods
+    puts 'Recreating accounting archives. This may take a while...'
+    periods.each do |p|
+      AccountingPeriod.create!(
+        start_at: p[:start_at],
+        end_at: p[:end_at],
+        closed_at: p[:closed_at],
+        closed_by: p[:closed_by]
+      )
+    end
+    # 2. reset protection for AccountingPeriods
+    execute("CREATE RULE accounting_periods_del_protect AS ON DELETE TO #{AccountingPeriod.arel_table.name} DO INSTEAD NOTHING;")
+  end
+
+
   def find_reservable(invoice_item)
     descr = /^([a-zA-Z\u00C0-\u017F]+\s+)+/.match(invoice_item.description)[0].strip[/(.*)\s/, 1]
     reservable = InvoiceItem.where('description LIKE ?', "#{descr}%")
@@ -70,6 +130,7 @@ class FixInvoicesWithoutInvoicedId < ActiveRecord::Migration[5.2]
 
   def find_slots(invoice)
     invoice.invoice_items.map do |ii|
+      # FIXME, datetime parsing is KO
       start = DateTime.parse(ii.description)
       end_time = DateTime.parse(/- (.+)$/.match(ii.description)[1])
       [start, DateTime.new(start.year, start.month, start.day, end_time.hour, end_time.min, end_time.sec, end_time.zone)]
@@ -81,7 +142,8 @@ class FixInvoicesWithoutInvoicedId < ActiveRecord::Migration[5.2]
 
     availability = reservable.availabilities.where('start_at <= ? AND end_at >= ?', slot[0], slot[1]).first
     unless availability
-      STDERR.puts "WARNING: Unable to find an availability for #{reservable.class.name} #{reservable.id}, at #{slot[0]}..."
+      STDERR.puts "WARNING: Unable to find an availability for #{reservable.class.name} #{reservable.id}, at #{slot[0]}, creating..."
+      availability = reservable.availabilities.create!(start_at: slot[0], end_at: slot[1])
     end
     availability
   end
@@ -91,7 +153,7 @@ class FixInvoicesWithoutInvoicedId < ActiveRecord::Migration[5.2]
       {
         start_at: slot[0],
         end_at: slot[1],
-        availability_id: find_availability(reservable, slot).id,
+        availability_id: find_availability(reservable, slot)&.id,
         offered: invoice.total.zero?
       }
     end