diff --git a/CHANGELOG.md b/CHANGELOG.md index 475f4995b..079a5adec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,15 @@ # Changelog Fab-manager +## v5.3.10 2022 April 12 + +- Updated generate invoice reference method +- Set invoice reference is required +- Fix a bug: unable to show machine availability slot for admin +- Fix a bug: unable to confirm modification of reservation for client +- Fix a bug: unable to show deleted user in reservation slot +- Fix a bug: race condition on invoice after payment (concerning payment schedules) https://app.clickup.com/t/25zpmn1 +- Fix a bug: form maxlength count to exclude spaces and newline + ## v5.3.9 2022 April 01 - Optimise sql query, avoid to N+1 diff --git a/app/frontend/src/javascript/controllers/machines.js.erb b/app/frontend/src/javascript/controllers/machines.js.erb index 26f83c140..cacd5cd1a 100644 --- a/app/frontend/src/javascript/controllers/machines.js.erb +++ b/app/frontend/src/javascript/controllers/machines.js.erb @@ -499,7 +499,7 @@ Application.Controllers.controller('ReserveMachineController', ['$scope', '$tran slotId: $scope.events.modifiable.slot_id, borderColor: $scope.events.modifiable.borderColor, user: angular.copy($scope.events.modifiable.user), - title: $scope.currentUser.id === $scope.events.modifiable.user.id ? _t('app.logged.machines_reserve.i_ve_reserved') : _t('app.logged.machines_reserve.not_available') + title: (!$scope.events.modifiable.user || $scope.currentUser.id === $scope.events.modifiable.user.id) ? _t('app.logged.machines_reserve.i_ve_reserved') : _t('app.logged.machines_reserve.not_available') }; $scope.events.modifiable.backgroundColor = 'white'; diff --git a/app/frontend/src/javascript/directives/cart.js b/app/frontend/src/javascript/directives/cart.js index da8865547..968b169e7 100644 --- a/app/frontend/src/javascript/directives/cart.js +++ b/app/frontend/src/javascript/directives/cart.js @@ -564,7 +564,12 @@ Application.Directives.directive('cart', ['$rootScope', '$uibModal', 'dialogs', return dialogs.confirm({ templateUrl: '/shared/confirm_modify_slot_modal.html', resolve: { - object () { return $scope.slot; } + object () { + if ($scope.slot.user && !$scope.slot.user.name) { + $scope.slot.user.name = _t('app.shared.confirm_modify_slot_modal.deleted_user'); + } + return $scope.slot; + } } } , function (type) { diff --git a/app/frontend/templates/admin/calendar/calendar.html b/app/frontend/templates/admin/calendar/calendar.html index c760602ef..637579fca 100644 --- a/app/frontend/templates/admin/calendar/calendar.html +++ b/app/frontend/templates/admin/calendar/calendar.html @@ -80,7 +80,8 @@
diff --git a/app/frontend/templates/admin/plans/_form.html b/app/frontend/templates/admin/plans/_form.html index 152c6ae73..278549909 100644 --- a/app/frontend/templates/admin/plans/_form.html +++ b/app/frontend/templates/admin/plans/_form.html @@ -7,6 +7,7 @@ name="plan[base_name]" class="form-control" ng-maxlength="24" + ng-trim="false" ng-model="plan.base_name" required="true"/> {{ 'app.shared.plan.name_is_required' }} diff --git a/app/frontend/templates/admin/plans/edit.html b/app/frontend/templates/admin/plans/edit.html index f7084c259..252036465 100644 --- a/app/frontend/templates/admin/plans/edit.html +++ b/app/frontend/templates/admin/plans/edit.html @@ -93,6 +93,13 @@ +{{ 'app.shared.confirm_modify_slot_modal.do_you_want_to_change_your_booking_slot_initially_planned_at' }}
-{{ 'app.shared.confirm_modify_slot_modal.do_you_want_to_change_NAME_s_booking_slot_initially_planned_at' }}
+{{ 'app.shared.confirm_modify_slot_modal.do_you_want_to_change_your_booking_slot_initially_planned_at' }}
+{{ 'app.shared.confirm_modify_slot_modal.do_you_want_to_change_NAME_s_booking_slot_initially_planned_at' }}
{{object.start | amDateFormat: 'LL'}} : {{object.start | amDateFormat:'LT'}} - {{object.end | amDateFormat:'LT'}}