From bdf94c68260aba488bc4706186401b3c697b21d2 Mon Sep 17 00:00:00 2001
From: Nicolas Florentin <nicolas@sleede.com>
Date: Fri, 10 Nov 2023 09:13:23 +0100
Subject: [PATCH] (feat) when deleting an event, all reservations are canceled

---
 CHANGELOG.md                                       |  1 +
 app/frontend/templates/events/deleteRecurrent.html |  1 +
 app/services/event_service.rb                      | 11 ++++++++++-
 app/services/slots_reservations_service.rb         |  2 +-
 config/locales/app.public.en.yml                   |  1 +
 db/structure.sql                                   |  3 ++-
 test/integration/events/delete_test.rb             |  7 ++++++-
 7 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 17bf62ff7..9b335c9e5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@
 - updates spanish translations
 - Fix a bug: avoids crash due to oidc config with scope = nil
 - Fix a bug: unable to see value for input group with long label on eventModal
+- Improvement: when deleting an event, all reservations are canceled
 
 ## v6.3.0 2023 November 3
 
diff --git a/app/frontend/templates/events/deleteRecurrent.html b/app/frontend/templates/events/deleteRecurrent.html
index 9ed1a1847..90acecbf8 100644
--- a/app/frontend/templates/events/deleteRecurrent.html
+++ b/app/frontend/templates/events/deleteRecurrent.html
@@ -5,6 +5,7 @@
 <div class="modal-body">
   <p ng-hide="isRecurrent" translate>{{ 'app.public.events_show.do_you_really_want_to_delete_this_event' }}</p>
   <p ng-show="isRecurrent" translate>{{ 'app.public.events_show.delete_recurring_event' }}</p>
+  <p translate>{{ 'app.public.events_show.all_reservations_for_this_event_will_be_canceled' }}</p>
   <div ng-show="isRecurrent" class="form-group">
     <label class="checkbox">
       <input type="radio" name="delete_mode" ng-model="deleteMode" value="single" required/>
diff --git a/app/services/event_service.rb b/app/services/event_service.rb
index 7a6adcaf6..ec4d0d3bf 100644
--- a/app/services/event_service.rb
+++ b/app/services/event_service.rb
@@ -71,7 +71,16 @@ class EventService
       events.each do |e|
         method = e.destroyable? ? :destroy : :soft_destroy!
         # we use double negation because destroy can return either a boolean (false) or an Event (in case of delete success)
-        results.push status: !!e.send(method), event: e # rubocop:disable Style/DoubleNegation
+
+        ActiveRecord::Base.transaction do
+          status = !!e.send(method)
+          if status
+            e.reservations.preload(:slots_reservations).map(&:slots_reservations).flatten.map do |slots_reservation|
+              SlotsReservationsService.cancel(slots_reservation)
+            end
+          end
+          results.push status: status, event: e # rubocop:disable Style/DoubleNegation
+        end
       end
       results
     end
diff --git a/app/services/slots_reservations_service.rb b/app/services/slots_reservations_service.rb
index 3699083ae..774587514 100644
--- a/app/services/slots_reservations_service.rb
+++ b/app/services/slots_reservations_service.rb
@@ -5,7 +5,7 @@ class SlotsReservationsService
   class << self
     def cancel(slot_reservation)
       # first we mark ths slot reservation as cancelled in DB, to free a ticket
-      slot_reservation.update(canceled_at: Time.current)
+      slot_reservation.update!(canceled_at: Time.current)
 
       # then we try to remove this reservation from ElasticSearch, to keep the statistics up-to-date
       model_name = slot_reservation.reservation.reservable.class.name
diff --git a/config/locales/app.public.en.yml b/config/locales/app.public.en.yml
index f14ace6e9..3e51f5d1f 100644
--- a/config/locales/app.public.en.yml
+++ b/config/locales/app.public.en.yml
@@ -352,6 +352,7 @@ en:
         you_can_shift_this_reservation_on_the_following_slots: "You can shift this reservation on the following slots:"
         confirmation_required: "Confirmation required"
         do_you_really_want_to_delete_this_event:  "Do you really want to delete this event?"
+        all_reservations_for_this_event_will_be_canceled: All reservations for this event will be canceled.
         delete_recurring_event: "You're about to delete a periodic event. What do you want to do?"
         delete_this_event: "Only this event"
         delete_this_and_next: "This event and the following"
diff --git a/db/structure.sql b/db/structure.sql
index cda265f42..01fa2735d 100644
--- a/db/structure.sql
+++ b/db/structure.sql
@@ -9203,6 +9203,7 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20230831103208'),
 ('20230901090637'),
 ('20230907124230'),
-('20231103093436');
+('20231103093436'),
+('20231108094433');
 
 
diff --git a/test/integration/events/delete_test.rb b/test/integration/events/delete_test.rb
index 4799d5d4e..ec08f0582 100644
--- a/test/integration/events/delete_test.rb
+++ b/test/integration/events/delete_test.rb
@@ -5,6 +5,8 @@ require 'test_helper'
 module Events; end
 
 class Events::DeleteTest < ActionDispatch::IntegrationTest
+  include ActionMailer::TestHelper
+
   setup do
     admin = User.with_role(:admin).first
     login_as(admin, scope: :user)
@@ -55,7 +57,10 @@ class Events::DeleteTest < ActionDispatch::IntegrationTest
     assert_equal 201, response.status, response.body
 
     assert_not event.destroyable?
-    delete "/api/events/#{event.id}?mode=single", headers: default_headers
+    assert_enqueued_emails 2 do
+      delete "/api/events/#{event.id}?mode=single", headers: default_headers
+    end
+    assert event.availability.slots_reservations.all? { |sr| sr.canceled_at }
     assert_response :success
     res = json_response(response.body)
     assert_equal 1, res[:deleted]