From ce7b737163e7b7b998794a599f3c57eae96dbd44 Mon Sep 17 00:00:00 2001 From: Sylvain Date: Wed, 4 Jan 2017 14:48:32 +0100 Subject: [PATCH] possible workaround for orphan InvoiceWorkers created with nil parameter Moreover, a log was added on job creation, to help debugging if this does not fix the issue --- app/models/invoice.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/models/invoice.rb b/app/models/invoice.rb index 3facee497..2d699c466 100644 --- a/app/models/invoice.rb +++ b/app/models/invoice.rb @@ -13,7 +13,7 @@ class Invoice < ActiveRecord::Base has_one :avoir, class_name: 'Invoice', foreign_key: :invoice_id, dependent: :destroy after_create :update_reference - after_commit :generate_and_send_invoice, on: [:create] + after_commit :generate_and_send_invoice, on: [:create], :if => :persisted? def file dir = "invoices/#{user.id}" @@ -204,6 +204,7 @@ class Invoice < ActiveRecord::Base private def generate_and_send_invoice + puts "Creating an InvoiceWorker job to generate the following invoice: id(#{id}), invoiced_id(#{invoiced_id}), invoiced_type(#{invoiced_type}), user_id(#{user_id})" InvoiceWorker.perform_async(id) end