[bug] invalid notification text when sending amount coupon

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Ability for admins to configure the maximum visibility for availabilities reservation
 - Fix a bug: admins cannot see all availabilities for spaces in reservation calendar when a user is selected
 - Fix a bug: missing translation after payment in english and portuguese
+- Fix a bug: invalid notification when sending monetary coupon to users
 - Updated puma for compatibility with openSSL > 1.0
 - Documented installation on ArchLinux
 - [TODO DEPLOY] `rake db:seed`

app/views/api/notifications/_notify_member_about_coupon.json.jbuilder

@@ -1,5 +1,11 @@
 json.title notification.notification_type
-json.description t('.enjoy_a_discount_of_PERCENT_with_code_CODE',
-                   PERCENT: notification.attached_object.percent_off,
-                   CODE: notification.attached_object.code)
+if notification.attached_object.type == 'percent_off'
+  json.description t('.enjoy_a_discount_of_PERCENT_with_code_CODE',
+                     PERCENT: notification.attached_object.percent_off,
+                     CODE: notification.attached_object.code)
+else
+  json.description t('.enjoy_a_discount_of_AMOUNT_with_code_CODE',
+                     AMOUNT: number_to_currency(notification.attached_object.amount_off / 100.00),
+                     CODE: notification.attached_object.code)
+end
 json.url notification_url(notification, format: :json)

app/views/notifications_mailer/notify_member_about_coupon.html.erb

@@ -15,7 +15,7 @@
 <% end %>
 
 <%
-  # we must tell the use if he could use the code just once or many times (in case we won't specify)
+  # we must tell the user if he can use the code just once or many times (== maximum wasn't specified)
   usages = 999 # just a number > 1
   if @attached_object.validity_per_user == 'once'
     usages = 1

config/locales/en.yml

@@ -306,6 +306,7 @@ en:
         download_here: "Download here"
       notify_member_about_coupon:
         enjoy_a_discount_of_PERCENT_with_code_CODE: "Enjoy a discount of %{PERCENT}% with code %{CODE}"
+        enjoy_a_discount_of_AMOUNT_with_code_CODE: "Enjoy a discount of %{AMOUNT} with code %{CODE}"
 
   statistics:
     # statistics tools for admins

config/locales/fr.yml

@@ -306,6 +306,7 @@ fr:
         download_here: "Téléchargez ici"
       notify_member_about_coupon:
         enjoy_a_discount_of_PERCENT_with_code_CODE: "Bénéficiez d'une remise de %{PERCENT} % avec le code %{CODE}"
+        enjoy_a_discount_of_AMOUNT_with_code_CODE: "Bénéficiez d'une remise de %{AMOUNT} avec le code %{CODE}"
 
   statistics:
     # outil de statistiques pour les administrateurs

config/locales/pt.yml

@@ -306,6 +306,7 @@ pt:
         download_here: "Baixe aqui"
       notify_member_about_coupon:
         enjoy_a_discount_of_PERCENT_with_code_CODE: "Desfrute de um desconto de %{PERCENT}% com o código %{CODE}"
+        enjoy_a_discount_of_AMOUNT_with_code_CODE: "Desfrute de um desconto de %{AMOUNT} com o código %{CODE}"
 
   statistics:
     # statistics tools for admins