From 2b33aafdb9b8b2d9aa74411139dd316af5c1fd1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E9=82=88?= Date: Tue, 16 Feb 2016 20:05:50 +0800 Subject: [PATCH] add check for NULL conv --- pam_yubico.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pam_yubico.c b/pam_yubico.c index bc12566..859ba32 100644 --- a/pam_yubico.c +++ b/pam_yubico.c @@ -407,11 +407,15 @@ display_error(pam_handle_t *pamh, const char *message) { return retval; } + if(!conv || !conv->conv){ + D(("conv() function invalid")); + return PAM_CONV_ERR; + } pmsg[0] = &msg[0]; msg[0].msg = (char *) message; /* on some systems, pam_message.msg isn't const */ msg[0].msg_style = PAM_ERROR_MSG; retval = conv->conv(1, pmsg, &resp, conv->appdata_ptr); - + if (retval != PAM_SUCCESS) { D(("conv returned error: %s", pam_strerror (pamh, retval))); return retval;