rooty/yubico-pam
1
0
Fork 0
mirror of https://github.com/Yubico/yubico-pam.git synced 2024-11-29 09:24:22 +01:00
Code Issues Projects Releases Wiki Activity

Revert "Wait with declaring PAM_SUCCESS on challenge-response until new"

Browse Source 
Tollef has argued that the login should not fail if, for example, the
disk is full. I'd rather fail on the cautious side and make sure we
don't end up always sending the same challenge to the YubiKey, but I'll
leave it up to Tollef to decide for now.

This reverts commit 14e917ffae.

Conflicts:

	pam_yubico.c
This commit is contained in:
Fredrik Thulin 2011-03-17 15:08:23 +01:00
parent 0cf57429a8
commit 319fee4e08
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pam_yubico.c
View File

@ -472,9 +472,10 @@ do_challenge_response(struct cfg *cfg, const char *username)
yubikey_hex_encode(response_hex, (char *)response, response_len);
if (strcmp(response_hex, expected_response) != 0) {
D(("Unexpected C/R response : %s != %s", response_hex, expected_response));
ret = PAM_AUTH_ERR;
if (strcmp(response_hex, expected_response) == 0) {
ret = PAM_SUCCESS;
} else {
D(("Unexpected C/R response : %s", response_hex));
goto out;
}
@ -513,7 +514,6 @@ do_challenge_response(struct cfg *cfg, const char *username)
goto out;
D(("Challenge-response success!"));
ret = PAM_SUCCESS;
out:
if (yk_errno) {