rooty/yubico-pam
1
0
Fork 0
mirror of https://github.com/Yubico/yubico-pam.git synced 2025-02-27 06:54:15 +01:00
Code Issues Projects Releases Wiki Activity

Check whether fullpath can be constructed correctly

Browse Source 
This checks the return code of snprintf() and makes sure that fullpath
actually fits into a buffer of size PATH_MAX. Otherwise, it will output
an error and exit.
This commit is contained in:
Karol Babioch 2018-05-04 16:16:39 +02:00
parent daad39345d
commit a7c1d0adfd
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ykpamcfg.c
View File

@ -166,7 +166,12 @@ do_add_hmac_chalresp(YK_KEY *yk, uint8_t slot, bool verbose, char *output_dir, u
if (!output_dir){ if (!output_dir){
char fullpath[PATH_MAX]; char fullpath[PATH_MAX];
snprintf(fullpath, PATH_MAX, "%s/.yubico", p->pw_dir); int i = snprintf(fullpath, PATH_MAX, "%s/.yubico", p->pw_dir);
if (i < 0 || i >= PATH_MAX) {
fprintf(stderr, "Failed to construct fullpath: %s\n", p->pw_dir);
goto out;
}
//check if directory exists //check if directory exists
if (stat(fullpath,&st)!=0 ){ if (stat(fullpath,&st)!=0 ){