rooty/yubico-pam
1
0
Fork 0
mirror of https://github.com/Yubico/yubico-pam.git synced 2025-02-01 10:52:17 +01:00
Code Issues Projects Releases Wiki Activity

util_test: Use mkdtemp() instead of tempnam()

Browse Source 
The latter function is considered insecure and deprecated on some platforms.
This will create the directory with 0700 implicitely, where it was 0755
beforehand. Since this is a more secure default and the test suite runs fine,
we don't bother to chmod the directory.
This commit is contained in:
Karol Babioch 2018-04-06 16:59:28 +02:00
parent 49ad48b3ef
commit a92a59c761
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/util_test.c
View File

@ -180,12 +180,10 @@ static void test_check_user_challenge_file(void) {
unlink(buf); unlink(buf);
/* create temporary directory */ /* create temporary directory */
tmpdir_path = tempnam(NULL, "pamtest"); char template[] = "/tmp/pamtest.XXXXXX";
tmpdir_path = mkdtemp(template);
assert(tmpdir_path != NULL); assert(tmpdir_path != NULL);
ret = mkdir(tmpdir_path, 0755);
assert(ret == 0);
/* set user data */ /* set user data */
user.pw_name = "tester"; user.pw_name = "tester";
user.pw_dir = tmpdir_path; user.pw_dir = tmpdir_path;
@ -242,7 +240,6 @@ static void test_check_user_challenge_file(void) {
/* remove temporary directory */ /* remove temporary directory */
ret = rmdir(tmpdir_path); ret = rmdir(tmpdir_path);
assert(ret == 0); assert(ret == 0);
free(tmpdir_path);
free(buf); free(buf);
/* check test results */ /* check test results */