rooty/yubico-pam
1
0
Fork 0
mirror of https://github.com/Yubico/yubico-pam.git synced 2025-03-06 09:29:17 +01:00
Code Issues Projects Releases Wiki Activity

Make use of PATH_MAX for fullpath

Browse Source 
Instead of hardcoding the buffer size to 256, using PATH_MAX makes more
sense here, since this can be defined differently on different
platforms. This is not perfect, though, refer to [1] for some details.
In our case it should be good enough.

[1]: https://eklitzke.org/path-max-is-tricky
This commit is contained in:
Karol Babioch 2018-05-04 15:44:00 +02:00
parent fa3833b0a0
commit daad39345d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ykpamcfg.c
View File

@ -39,6 +39,7 @@
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/types.h> #include <sys/types.h>
#include <fcntl.h> #include <fcntl.h>
#include <limits.h>
#include <ykpers.h> #include <ykpers.h>
@ -164,8 +165,8 @@ do_add_hmac_chalresp(YK_KEY *yk, uint8_t slot, bool verbose, char *output_dir, u
*/ */
if (!output_dir){ if (!output_dir){
char fullpath[256]; char fullpath[PATH_MAX];
snprintf(fullpath, 256,"%s/.yubico",p->pw_dir); snprintf(fullpath, PATH_MAX, "%s/.yubico", p->pw_dir);
//check if directory exists //check if directory exists
if (stat(fullpath,&st)!=0 ){ if (stat(fullpath,&st)!=0 ){