rooty/yubico-pam
1
0
Fork 0
mirror of https://github.com/Yubico/yubico-pam.git synced 2025-01-19 07:52:23 +01:00
Code Issues Projects Releases Wiki Activity

don't write to a constant pointer

Browse Source 
instead allocate action on the stack and copy the data there
This commit is contained in:
Klas Lindfors 2014-10-31 09:21:06 +01:00
parent d1ab4539e4
commit e2f9a7b95c
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ykpamcfg.c
View File

@ -46,6 +46,7 @@
#include "util.h"
#define ACTION_ADD_HMAC_CHALRESP "add_hmac_chalresp"
#define ACTION_MAX_LEN 1024
const char *usage =
"Usage: ykpamcfg [options]\n"
@ -104,7 +105,7 @@ parse_args(int argc, char **argv,
*slot = 2;
break;
case 'A':
*action = optarg;
strncpy(*action, optarg, ACTION_MAX_LEN);
break;
case 'p':
*output_dir = optarg;
@ -257,7 +258,8 @@ main(int argc, char **argv)
/* Options */
bool verbose = false;
char *action = ACTION_ADD_HMAC_CHALRESP;
char action[ACTION_MAX_LEN];
char *ptr = action;
char *output_dir = NULL;
int slot = 1;
unsigned int iterations = CR_DEFAULT_ITERATIONS;
@ -265,15 +267,17 @@ main(int argc, char **argv)
ykp_errno = 0;
yk_errno = 0;
strcpy (action, ACTION_ADD_HMAC_CHALRESP);
if (! parse_args(argc, argv,
&slot, &verbose,
&action, &output_dir,
&ptr, &output_dir,
&iterations, &exit_code))
goto err;
exit_code = 1;
if (! strcmp(action, ACTION_ADD_HMAC_CHALRESP)) {
if (! strncmp(action, ACTION_ADD_HMAC_CHALRESP, ACTION_MAX_LEN)) {
/*
* Set up challenge-response login authentication
*/