rooty/yubico-pam
1
0
Fork 0
mirror of https://github.com/Yubico/yubico-pam.git synced 2025-03-03 18:29:17 +01:00
Code Issues Projects Releases Wiki Activity

util.c: Check for return codes of snprintf()

Browse Source
This commit is contained in:
Karol Babioch 2018-05-17 16:28:22 +02:00
parent 2f172e3227
commit f77893a11c
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
util.c
View File

@ -68,7 +68,10 @@ get_user_cfgfile_path(const char *common_path, const char *filename, const struc
if ((userfile = malloc(len)) == NULL) { if ((userfile = malloc(len)) == NULL) {
return 0; return 0;
} }
snprintf(userfile, len, "%s/%s", common_path, filename); int i = snprintf(userfile, len, "%s/%s", common_path, filename);
if (i < 0 || i >= len) {
return 0;
}
*fn = userfile; *fn = userfile;
return 1; return 1;
} }
@ -79,7 +82,10 @@ get_user_cfgfile_path(const char *common_path, const char *filename, const struc
if ((userfile = malloc(len)) == NULL) { if ((userfile = malloc(len)) == NULL) {
return 0; return 0;
} }
snprintf(userfile, len, "%s/.yubico/%s", user->pw_dir, filename); int i = snprintf(userfile, len, "%s/.yubico/%s", user->pw_dir, filename);
if (i < 0 || i >= len) {
return 0;
}
*fn = userfile; *fn = userfile;
return 1; return 1;
} }
@ -332,7 +338,14 @@ check_user_challenge_file(const char *chalresp_path, const struct passwd *user,
ret = AUTH_ERROR; ret = AUTH_ERROR;
goto out; goto out;
} }
snprintf(userfile_pattern, len, "%s-*", userfile);
int i = snprintf(userfile_pattern, len, "%s-*", userfile);
if (i < 0 || i >= len) {
D (debug_file, "Failed to format string correctly");
ret = AUTH_ERROR;
goto out;
}
r = glob(userfile_pattern, 0, NULL, &userfile_glob); r = glob(userfile_pattern, 0, NULL, &userfile_glob);
globfree(&userfile_glob); globfree(&userfile_glob);