From 283c34b0e4e0a3574a0b68e593cea2d54daebf10 Mon Sep 17 00:00:00 2001 From: Fredrik Thulin Date: Wed, 13 Jun 2012 10:10:04 +0200 Subject: [PATCH] Downgrade 'Sync request unnecessarily sent' to INFO. Also add comment explaining that this is not an error (and why). --- ykval-sync.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ykval-sync.php b/ykval-sync.php index 12c81af..31c2fcf 100644 --- a/ykval-sync.php +++ b/ykval-sync.php @@ -146,7 +146,14 @@ if ($sync->countersEqual($localParams, $syncParams)) { if ($syncParams['modified']==$localParams['modified'] && $syncParams['nonce']==$localParams['nonce']) { - $myLog->log(LOG_NOTICE, 'Sync request unnecessarily sent'); + /* This is not an error. When the remote server received an OTP to verify, it would + * have sent out sync requests immediately. When the required number of responses had + * been received, the current implementation discards all additional responses (to + * return the result to the client as soon as possible). If our response sent last + * time was discarded, we will end up here when the background ykval-queue processes + * the sync request again. + */ + $myLog->log(LOG_INFO, 'Sync request unnecessarily sent'); } if ($syncParams['modified']!=$localParams['modified'] &&