From 424fbdf962624e90dc400a89fceaead17b4b77f8 Mon Sep 17 00:00:00 2001 From: Jean Paul Galea Date: Tue, 21 Jul 2015 21:45:07 +0000 Subject: [PATCH] FIXME markers. --- ykval-verify.php | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/ykval-verify.php b/ykval-verify.php index 2d69dcd..e872e1c 100644 --- a/ykval-verify.php +++ b/ykval-verify.php @@ -38,10 +38,21 @@ $ipaddr = $_SERVER['REMOTE_ADDR']; $https = (array_key_exists('HTTPS', $_SERVER) === TRUE && strtolower($_SERVER['HTTPS']) !== 'off' ? TRUE : FALSE); +/** + * FIXME + * + * Refactor code which extracts the request arguments, + * pull it up here and avoid sprinlking the following in the "core": + * + * $_GET, $_POST, $_SERVER['QUERY_STRING'], getHttpVal() + * + * Avoid ambiguity with urldecode. + */ + $myLog = new Log('ykval-verify'); $myLog->addField('ip', $ipaddr); -// FIXME clean +// FIXME $message = ''; if ($_POST) {