From 7d4a2940d61efa8a37c532706f83a7d8b2088c92 Mon Sep 17 00:00:00 2001 From: Jean Paul Galea Date: Fri, 17 Jul 2015 00:03:41 +0200 Subject: [PATCH] Refactor. - parse request before opening up a database connection and init'ing synclib. --- ykval-sync.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ykval-sync.php b/ykval-sync.php index 410a0ec..0f53bb7 100644 --- a/ykval-sync.php +++ b/ykval-sync.php @@ -54,13 +54,6 @@ if (in_array($ipaddr, $allowed, TRUE) === FALSE) { } -$sync = new SyncLib('ykval-sync:synclib'); -$sync->addField('ip', $ipaddr); - -if (! $sync->isConnected()) { - sendResp(S_BACKEND_ERROR, $myLog); -} - // define requirements on protocol $syncParams = array( 'modified' => NULL, @@ -87,6 +80,13 @@ foreach ($syncParams as $param=>$value) { $myLog->log(LOG_INFO, $tmp_log); +$sync = new SyncLib('ykval-sync:synclib'); +$sync->addField('ip', $ipaddr); + +if (! $sync->isConnected()) { + sendResp(S_BACKEND_ERROR, $myLog); +} + // at this point we should have the otp so let's add it to the logging module $myLog->addField('otp', $syncParams['otp']); $sync->addField('otp', $syncParams['otp']);