rooty/yubikey-val
1
0
Fork 0
mirror of https://github.com/Yubico/yubikey-val.git synced 2025-02-08 03:54:20 +01:00
Code Issues Projects Releases Wiki Activity

Refactor.

Browse Source 
- enable strict comparison for sscanf result.

- use single quotes where possible.

- styling.
This commit is contained in:
Jean Paul Galea 2015-07-17 21:50:28 +02:00
parent 45ea62445c
commit a28ad6df69
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ykval-common.php
View File

@ -224,7 +224,7 @@ function KSMdecryptOTP($urls, $logger, $curlopts)
$urls = array($urls);
}
$response = retrieveURLasync("YK-KSM", $urls, $logger, $ans_req=1, $match="^OK", $returl=False, $timeout=10, $curlopts);
$response = retrieveURLasync('YK-KSM', $urls, $logger, $ans_req=1, $match='^OK', $returl=False, $timeout=10, $curlopts);
if (is_array($response))
{
@ -233,10 +233,15 @@ function KSMdecryptOTP($urls, $logger, $curlopts)
if ($response)
{
$logger->log(LOG_DEBUG, log_format("YK-KSM response: ", $response));
$logger->log(LOG_DEBUG, log_format('YK-KSM response: ', $response));
}
if (sscanf($response, "OK counter=%04x low=%04x high=%02x use=%02x", $ret["session_counter"], $ret["low"], $ret["high"], $ret["session_use"]) != 4)
if (sscanf($response,
'OK counter=%04x low=%04x high=%02x use=%02x',
$ret['session_counter'],
$ret['low'],
$ret['high'],
$ret['session_use'] !== 4)
{
return false;
}